From 0c6e5e713e2a1e71e560d6a8d5ba058eea0b7ac9 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Tue, 7 Feb 2012 11:42:06 +0100 Subject: [PATCH] core: plug leaks when passing GValueArrays to dbus_g_method_return() The ownership of the GValueArray is not transferred. --- src/mm-modem-cdma.c | 2 ++ src/mm-modem-gsm-network.c | 2 ++ src/mm-modem.c | 4 ++++ 3 files changed, 8 insertions(+) diff --git a/src/mm-modem-cdma.c b/src/mm-modem-cdma.c index 485e5f28..7583760e 100644 --- a/src/mm-modem-cdma.c +++ b/src/mm-modem-cdma.c @@ -131,6 +131,8 @@ serving_system_call_done (MMModemCdma *self, g_value_unset (&value); dbus_g_method_return (context, array); + + g_value_array_free (array); } } diff --git a/src/mm-modem-gsm-network.c b/src/mm-modem-gsm-network.c index cd08d855..2863aafd 100644 --- a/src/mm-modem-gsm-network.c +++ b/src/mm-modem-gsm-network.c @@ -202,6 +202,8 @@ reg_info_call_done (MMModemGsmNetwork *self, g_value_unset (&value); dbus_g_method_return (context, array); + + g_value_array_free (array); } } diff --git a/src/mm-modem.c b/src/mm-modem.c index 0b31108b..a78587b2 100644 --- a/src/mm-modem.c +++ b/src/mm-modem.c @@ -325,6 +325,8 @@ get_ip4_done (MMModem *modem, value_array_add_uint (array, dns3); dbus_g_method_return (context, array); + + g_value_array_free (array); } } @@ -413,6 +415,8 @@ info_call_done (MMModem *self, g_value_unset (&value); dbus_g_method_return (context, array); + + g_value_array_free (array); } }