From 5b8da2e1b96e8319bda959119de123f03b988d61 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Mon, 16 Sep 2019 11:45:21 +0200 Subject: [PATCH] broadband-modem-qmi: add note about index_of_running_image known issue Since 02.20.xx.xx, the 'index_of_running_image' reported for MODEM images is wrong. https://forum.sierrawireless.com/t/mc74xx-wrong-running-image-in-qmi-get-stored-images/8998 --- src/mm-broadband-modem-qmi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/mm-broadband-modem-qmi.c b/src/mm-broadband-modem-qmi.c index 06e29c05..87502011 100644 --- a/src/mm-broadband-modem-qmi.c +++ b/src/mm-broadband-modem-qmi.c @@ -7342,7 +7342,14 @@ list_stored_images_ready (QmiClientDms *client, pair->build_id = g_strdup (subimage_pri->build_id); pair->modem_unique_id = g_array_ref (subimage_modem->unique_id); pair->pri_unique_id = g_array_ref (subimage_pri->unique_id); + + /* We're using the PRI 'index_of_running_image' only as source to select + * which is the current running firmware. This avoids issues with the wrong + * 'index_of_running_image' reported for the MODEM images, see: + * https://forum.sierrawireless.com/t/mc74xx-wrong-running-image-in-qmi-get-stored-images/8998 + */ pair->current = (image_pri->index_of_running_image == i ? TRUE : FALSE); + ctx->pairs = g_list_append (ctx->pairs, pair); break; }