From 727567cf581f9126b5af6aff2944f3734877d999 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Mon, 10 Sep 2018 23:03:12 +0200 Subject: [PATCH] broadband-bearer: no need for explicit flow control cleanup on disconnect We're already configuring the flow control we expect when running mm_port_serial_reopen(), which will keep the udev-selected flow control or will otherwise reset to no flow control when the TTY is in command mode. --- src/mm-broadband-bearer.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/src/mm-broadband-bearer.c b/src/mm-broadband-bearer.c index 779cd9a3..bf02c13a 100644 --- a/src/mm-broadband-bearer.c +++ b/src/mm-broadband-bearer.c @@ -1418,16 +1418,6 @@ data_flash_cdma_ready (MMPortSerial *data, mm_port_serial_flash_finish (data, res, &error); - /* Cleanup flow control */ - if (self->priv->flow_control != MM_FLOW_CONTROL_NONE) { - GError *flow_control_error = NULL; - - if (!mm_port_serial_set_flow_control (MM_PORT_SERIAL (data), MM_FLOW_CONTROL_NONE, &flow_control_error)) { - mm_dbg ("Couldn't reset flow control settings: %s", flow_control_error->message); - g_clear_error (&flow_control_error); - } - } - /* We kept the serial port open during connection, now we close that open * count */ mm_port_serial_close (data); @@ -1560,16 +1550,6 @@ data_flash_3gpp_ready (MMPortSerial *data, mm_port_serial_flash_finish (data, res, &error); - /* Cleanup flow control */ - if (self->priv->flow_control != MM_FLOW_CONTROL_NONE) { - GError *flow_control_error = NULL; - - if (!mm_port_serial_set_flow_control (MM_PORT_SERIAL (data), MM_FLOW_CONTROL_NONE, &flow_control_error)) { - mm_dbg ("Couldn't reset flow control settings: %s", flow_control_error->message); - g_clear_error (&flow_control_error); - } - } - /* We kept the serial port open during connection, now we close that open * count */ mm_port_serial_close (data);