From 7c8d0d1718446e32a107c7a9363cf936d5865d39 Mon Sep 17 00:00:00 2001
From: Aleksander Morgado <aleksander@aleksander.es>
Date: Mon, 23 Sep 2019 15:32:51 +0200
Subject: [PATCH] broadband-modem: skip redundant ATE0/AT+CMEE=1 settings

These are already given in the logic behind the
"MM_PORT_SERIAL_AT_INIT_SEQUENCE"  property:

    (ttyACM1): --> 'ATE0<CR>'
    (ttyACM1): <-- '<CR><LF>OK<CR><LF>'
    (ttyACM1): --> 'ATV1<CR>'
    (ttyACM1): <-- '<CR><LF>OK<CR><LF>'
    (ttyACM1): --> 'AT+CMEE=1<CR>'
    (ttyACM1): <-- '<CR><LF>OK<CR><LF>'
    (ttyACM1): --> 'ATX4<CR>'
    (ttyACM1): <-- '<CR><LF>OK<CR><LF>'
    (ttyACM1): --> 'AT&C1<CR>'
    (ttyACM1): <-- '<CR><LF>OK<CR><LF>'
    (ttyACM1): --> 'ATE0<CR>'               --> redundant
    (ttyACM1): <-- '<CR><LF>OK<CR><LF>'
    (ttyACM1): --> 'AT+CMEE=1<CR>'          --> redundant
    (ttyACM1): <-- '<CR><LF>OK<CR><LF>'
---
 src/mm-broadband-modem.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c
index 9c9c0908..ddfc70c8 100644
--- a/src/mm-broadband-modem.c
+++ b/src/mm-broadband-modem.c
@@ -9869,17 +9869,6 @@ open_ports_initialization (MMBroadbandModem *self,
 
     ctx->primary_open = TRUE;
 
-    /* Try to disable echo */
-    mm_base_modem_at_command_full (MM_BASE_MODEM (self),
-                                   ctx->primary,
-                                   "E0", 3,
-                                   FALSE, FALSE, NULL, NULL, NULL);
-    /* Try to get extended errors */
-    mm_base_modem_at_command_full (MM_BASE_MODEM (self),
-                                   ctx->primary,
-                                   "+CMEE=1", 3,
-                                   FALSE, FALSE, NULL, NULL, NULL);
-
     return TRUE;
 }