From 7ec338dafe52e87b3e24c993b796ce41e473946d Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Thu, 17 Oct 2024 09:06:21 +0000 Subject: [PATCH] cinterion: fix propagating NULL GError (ModemManager:2925): GLib-CRITICAL **: 09:21:32.082: g_propagate_error: assertion 'src != NULL' failed (ModemManager:2925): GLib-GIO-CRITICAL **: 09:21:32.083: g_task_return_error: assertion 'error != NULL' failed` Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/916 --- src/plugins/cinterion/mm-modem-helpers-cinterion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/cinterion/mm-modem-helpers-cinterion.c b/src/plugins/cinterion/mm-modem-helpers-cinterion.c index 34116ac3..e429cbc1 100644 --- a/src/plugins/cinterion/mm-modem-helpers-cinterion.c +++ b/src/plugins/cinterion/mm-modem-helpers-cinterion.c @@ -571,8 +571,8 @@ mm_cinterion_parse_scfg_sim_response (const gchar *response, } if (!mm_get_uint_from_match_info (match_info, 1, active_slot)) { - g_prefix_error (&inner_error, "Could not parse SIM slot index: "); - g_propagate_error (error, inner_error); + g_set_error (error, MM_CORE_ERROR, MM_CORE_ERROR_FAILED, + "Could not parse SIM slot index in ^SCFG response"); return FALSE; }