From 92cc41e06059cf9c5e9181443c933b47443ed8c0 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Thu, 30 Jan 2020 18:35:01 +0100 Subject: [PATCH] option: fix warnings with -Wimplicit-fallthrough MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit option/mm-broadband-modem-option.c: In function ‘load_access_technologies_step’: option/mm-broadband-modem-option.c:565:18: error: this statement may fall through [-Werror=implicit-fallthrough=] 565 | ctx->step++; | ~~~~~~~~~^~ option/mm-broadband-modem-option.c:567:5: note: here 567 | case ACCESS_TECHNOLOGIES_STEP_OSSYS: | ^~~~ option/mm-broadband-modem-option.c:587:18: error: this statement may fall through [-Werror=implicit-fallthrough=] 587 | ctx->step++; | ~~~~~~~~~^~ option/mm-broadband-modem-option.c:589:5: note: here 589 | case ACCESS_TECHNOLOGIES_STEP_OWCTI: | ^~~~ option/mm-broadband-modem-option.c:600:18: error: this statement may fall through [-Werror=implicit-fallthrough=] 600 | ctx->step++; | ~~~~~~~~~^~ option/mm-broadband-modem-option.c:602:5: note: here 602 | case ACCESS_TECHNOLOGIES_STEP_LAST: | ^~~~ --- plugins/option/mm-broadband-modem-option.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/option/mm-broadband-modem-option.c b/plugins/option/mm-broadband-modem-option.c index 8103932a..82ec58d0 100644 --- a/plugins/option/mm-broadband-modem-option.c +++ b/plugins/option/mm-broadband-modem-option.c @@ -561,8 +561,8 @@ load_access_technologies_step (GTask *task) switch (ctx->step) { case ACCESS_TECHNOLOGIES_STEP_FIRST: - /* Go on to next step */ ctx->step++; + /* fall through */ case ACCESS_TECHNOLOGIES_STEP_OSSYS: mm_base_modem_at_command (MM_BASE_MODEM (self), @@ -583,8 +583,8 @@ load_access_technologies_step (GTask *task) task); return; } - /* Go on to next step */ ctx->step++; + /* fall through */ case ACCESS_TECHNOLOGIES_STEP_OWCTI: if (ctx->check_3g) { @@ -596,8 +596,8 @@ load_access_technologies_step (GTask *task) task); return; } - /* Go on to next step */ ctx->step++; + /* fall through */ case ACCESS_TECHNOLOGIES_STEP_LAST: /* All done, set result and complete */