From af48e1c8b7b4cdc4212540d0f893a09f68630959 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Fri, 2 Nov 2012 14:29:52 +0100 Subject: [PATCH] broadband-modem-qmi: by default request only GSM-WCDMA mode messages This should probably fix the issues seen with the Novatel E362 (CDMA+LTE): ModemManager[4813]: [1351697325.212782] [mm-broadband-modem-qmi.c:5541] load_initial_sms_parts(): loading messages from storage 'sm'... ModemManager[4813]: [/dev/cdc-wdm0] Sending message... <<<<<< QMUX: <<<<<< length = 16 <<<<<< flags = 0x00 <<<<<< service = "wms" <<<<<< client = 2 <<<<<< QMI: <<<<<< flags = "none" <<<<<< transaction = 3 <<<<<< tlv_length = 4 <<<<<< message = "List Messages" (0x0031) <<<<<< TLV: <<<<<< type = "Storage Type" (0x01) <<<<<< length = 1 <<<<<< value = 01 <<<<<< translated = 1 ModemManager[4813]: [/dev/cdc-wdm0] Received message... >>>>>> QMUX: >>>>>> length = 19 >>>>>> flags = 0x80 >>>>>> service = "wms" >>>>>> client = 2 >>>>>> QMI: >>>>>> flags = "response" >>>>>> transaction = 3 >>>>>> tlv_length = 7 >>>>>> message = "List Messages" (0x0031) >>>>>> TLV: >>>>>> type = "Result" (0x02) >>>>>> length = 4 >>>>>> value = 01:00:11:00 >>>>>> translated = FAILURE: MissingArgument ModemManager[4813]: [1351697325.215112] [mm-iface-modem-messaging.c:757] load_initial_sms_parts_ready(): Couldn't load SMS parts from storage 'sm': 'Couldn't list messages: QMI protocol error (17): 'MissingArgument'' --- src/mm-broadband-modem-qmi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/mm-broadband-modem-qmi.c b/src/mm-broadband-modem-qmi.c index 033b74cf..53b7dfc8 100644 --- a/src/mm-broadband-modem-qmi.c +++ b/src/mm-broadband-modem-qmi.c @@ -5571,6 +5571,10 @@ load_initial_sms_parts (MMIfaceModemMessaging *self, input, mm_sms_storage_to_qmi_storage_type (storage), NULL); + qmi_message_wms_list_messages_input_set_message_mode ( + input, + QMI_WMS_MESSAGE_MODE_GSM_WCDMA, + NULL); qmi_client_wms_list_messages (QMI_CLIENT_WMS (ctx->client), input, 5,