From b2d52001e41db05490752699c09493c10d7af802 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Wed, 20 Nov 2024 12:48:03 +0100 Subject: [PATCH] broadband-modem-qmi: avoid conditional jump due to uninitialized variable in network reject indications ==3851== Conditional jump or move depends on uninitialised value(s) ==3851== at 0x23CF65: network_reject_indication_cb (mm-broadband-modem-qmi.c:5434) ==3851== by 0x4D00865: g_cclosure_marshal_VOID__BOXEDv (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.7200.4) ==3851== by 0x4D196FF: g_signal_emit_valist (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.7200.4) ==3851== by 0x4D19862: g_signal_emit (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.7200.4) ==3851== by 0x4F7C250: process_indication (qmi-nas.c:70290) ==3851== by 0x4DFA6C4: __qmi_client_process_indication (qmi-client.c:172) ==3851== by 0x4DFEE2D: process_indication_idle (qmi-device.c:1697) ==3851== by 0x4A26C43: g_main_context_dispatch (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7200.4) ==3851== by 0x4A7C2B7: ??? (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7200.4) ==3851== by 0x4A262B2: g_main_loop_run (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7200.4) ==3851== by 0x178042: main (main.c:236) Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/931 --- src/mm-broadband-modem-qmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mm-broadband-modem-qmi.c b/src/mm-broadband-modem-qmi.c index 8a90edc5..31bfa05d 100644 --- a/src/mm-broadband-modem-qmi.c +++ b/src/mm-broadband-modem-qmi.c @@ -5408,7 +5408,7 @@ network_reject_indication_cb (QmiClientNas *client, guint16 mcc = 0; guint16 mnc = 0; guint32 closed_subscriber_group = 0; - gboolean has_pcs_digit; + gboolean has_pcs_digit = FALSE; mm_obj_warn (self, "network reject indication received"); if (qmi_indication_nas_network_reject_output_get_service_domain (output, &service_domain, NULL))