From b4e0fa3d89ab4d8b053769335a489cd4517b68ae Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Fri, 31 Aug 2012 14:23:11 +0200 Subject: [PATCH] sierra: skip echo removal in the secondary port This is the port to git master of the following commit: commit d1be19d231a395339b1f452d1a30b73ea77ad528 Author: Dan Williams Date: Tue Aug 28 21:58:43 2012 -0500 sierra: fix CSQ handling on APP1 port The APP1 port doesn't always prefix its replies with which runs afoul of the built-in echo removal. Since Sierra modems are on the whole well-behaved WRT echo removal, just disable it on the secondary ports. Only changes behavior for PPP-based devices since they are the only ones that use the APP1 ports. --- plugins/sierra/mm-common-sierra.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/plugins/sierra/mm-common-sierra.c b/plugins/sierra/mm-common-sierra.c index fb71e049..1af64af4 100644 --- a/plugins/sierra/mm-common-sierra.c +++ b/plugins/sierra/mm-common-sierra.c @@ -215,6 +215,15 @@ mm_common_sierra_setup_ports (MMBroadbandModem *self) MM_PORT_CARRIER_DETECT, FALSE, NULL); + if (i == 1) { + /* Built-in echo removal conflicts with the APP1 port's limited AT + * parser, which doesn't always prefix responses with . + */ + g_object_set (ports[i], + MM_AT_SERIAL_PORT_REMOVE_ECHO, FALSE, + NULL); + } + mm_at_serial_port_add_unsolicited_msg_handler ( ports[i], pacsp0_regex,