helpers: new macro to CLAMP high threshold only
Useful when clamping a unsigned integer with low threshold set to 0,
which would give us compiler warnings with -Wtype-limits when using
CLAMP(), e.g.:
via/mm-broadband-modem-via.c: In function ‘handle_evdo_quality_change’:
/usr/include/glib-2.0/glib/gmacros.h:811:63: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
811 | #define CLAMP(x, low, high) (((x) > (high)) ? (high) : (((x) < (low)) ? (low) : (x)))
| ^
via/mm-broadband-modem-via.c:284:19: note: in expansion of macro ‘CLAMP’
284 | quality = CLAMP (quality, 0, 100);
| ^~~~~
This commit is contained in:
@@ -281,7 +281,7 @@ handle_evdo_quality_change (MMPortSerialAt *port,
|
||||
guint quality = 0;
|
||||
|
||||
if (mm_get_uint_from_match_info (match_info, 1, &quality)) {
|
||||
quality = CLAMP (quality, 0, 100);
|
||||
quality = MM_CLAMP_HIGH (quality, 100);
|
||||
mm_dbg ("EVDO signal quality: %u", quality);
|
||||
mm_iface_modem_update_signal_quality (MM_IFACE_MODEM (self), quality);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user