From cddc4af7bd18b93214ac270295b6410db1e0749f Mon Sep 17 00:00:00 2001
From: Ben Chan <benchan@chromium.org>
Date: Thu, 2 Jan 2014 15:56:33 -0800
Subject: [PATCH] huawei: report an error when ^PREFMODE reports no valid
 values

This patch fixes mm_huawei_parse_prefmode_test to always report an error when
returning NULL, which avoid a potential crash when the caller tries to access
the error.
---
 plugins/huawei/mm-modem-helpers-huawei.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/plugins/huawei/mm-modem-helpers-huawei.c b/plugins/huawei/mm-modem-helpers-huawei.c
index 926ca770..07a56979 100644
--- a/plugins/huawei/mm-modem-helpers-huawei.c
+++ b/plugins/huawei/mm-modem-helpers-huawei.c
@@ -341,6 +341,10 @@ mm_huawei_parse_prefmode_test (const gchar *response,
     /* No value */
     if (out->len == 0) {
         g_array_unref (out);
+        g_set_error (error,
+                     MM_CORE_ERROR,
+                     MM_CORE_ERROR_FAILED,
+                     "^PREFMODE response contains no valid values");
         return NULL;
     }