From d8b70602c51b77356eb439d63c4cac311d867310 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Fri, 15 May 2020 15:09:33 +0200 Subject: [PATCH] huawei: ignore NDISDUP disconnection errors Running NDISDUP=1,0 on an already disconnected bearer/context will report ERROR, so we can really ignore the result of the command, because we're anyway going to get the correct bearer/context status later on with the NDISSTATQRY checks. --- plugins/huawei/mm-broadband-bearer-huawei.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/plugins/huawei/mm-broadband-bearer-huawei.c b/plugins/huawei/mm-broadband-bearer-huawei.c index 4206f194..ca20c655 100644 --- a/plugins/huawei/mm-broadband-bearer-huawei.c +++ b/plugins/huawei/mm-broadband-bearer-huawei.c @@ -651,7 +651,6 @@ disconnect_ndisdup_ready (MMBaseModem *modem, { GTask *task; Disconnect3gppContext *ctx; - GError *error = NULL; task = self->priv->disconnect_pending; g_assert (task != NULL); @@ -661,13 +660,11 @@ disconnect_ndisdup_ready (MMBaseModem *modem, /* Balance refcount */ g_object_unref (self); - if (!mm_base_modem_at_command_full_finish (modem, res, &error)) { - /* Clear task */ - self->priv->disconnect_pending = NULL; - g_task_return_error (task, error); - g_object_unref (task); - return; - } + /* Running NDISDUP=1,0 on an already disconnected bearer/context will + * return ERROR! Ignore errors in the NDISDUP disconnection command, + * because we're anyway going to check the bearer/context status + * afterwards. */ + mm_base_modem_at_command_full_finish (modem, res, NULL); /* Go to next step */ ctx->step++;