From ef644fba84544c1a91b3fd2b510e39f9877b3680 Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Tue, 27 Nov 2012 09:54:51 -0600 Subject: [PATCH] hso: DIAG ports aren't always DIAG The 'hso' driver tags Icera-based modems' proprietary protocol port as a DIAG port, but since they aren't Qualcomm-based, it's not a DIAG port. Just turn off AT probing and let QCDM probing fail the port instead of assuming it's a DIAG port. --- plugins/option/mm-plugin-hso.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/plugins/option/mm-plugin-hso.c b/plugins/option/mm-plugin-hso.c index a11d6081..8fe18c44 100644 --- a/plugins/option/mm-plugin-hso.c +++ b/plugins/option/mm-plugin-hso.c @@ -89,7 +89,12 @@ hso_custom_init (MMPortProbe *probe, mm_port_probe_set_result_qcdm (probe, FALSE); } else if (g_str_has_prefix (contents, "Diag")) { g_object_set_data (G_OBJECT (probe), TAG_HSO_DIAG, GUINT_TO_POINTER (TRUE)); - mm_port_probe_set_result_qcdm (probe, TRUE); + mm_port_probe_set_result_at (probe, FALSE); + + /* Don't automatically tag as QCDM, as the 'hso' driver reports + * a DIAG port for some Icera-based modems, which don't have + * QCDM ports since they aren't made by Qualcomm. + */ } g_free (contents); }