9246 Commits
Author SHA1 Message Date
Dan Williams b5ad830fc7 Merge request !1253 from 'persist_current_storage'
messaging: load default storage from modem during initialization

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1253
2025-02-27 15:18:46 +00:00
Akula Susmitha bf5245bb27 messaging: load default storage from modem during initialization
Signed-off-by: Akula Susmitha <quic_asusmith@quicinc.com>
2025-02-27 15:04:59 +00:00
Dan Williams 21da676eed Merge request !1299 from 'dco3'
ci: fix a couple DCO check issues

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1299
2025-02-27 15:04:25 +00:00
Dan Williams 0bf02c88cb ci: fix job image ordering
With the FDO CI templates, the first container used must
be .fdo.container-build@ubuntu which builds the actual
container the rest of the pipeline can use with
.fdo.distribution-image@ubuntu.

.fdo.container-build@ubuntu uses a static 'image:' tag for
its job base image and then pushes to the project registry.
If the first job incorrectly uses .fdo.distribution-image@ubuntu
instead, it appears to fail for MR branches because that target
uses CI_REGISTRY_USER as part of the 'image:' tag which gitlab
sets to the username of the submitter. Which of course fails
because that user has never built the image before...

Using Docker executor with image registry.freedesktop.org/<username>/modemmanager/ubuntu/20.04:2023-01-03.1 ...
Authenticating with credentials from job payload (GitLab Registry)
Pulling docker image registry.freedesktop.org/<username>/modemmanager/ubuntu/20.04:2023-01-03.1 ...

Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-02-27 08:06:10 -06:00
Dan Williams 2a65ca978d ci: de-verbosify DCO check
Only print out the specific commits that fail DCO.

Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-02-27 08:06:01 -06:00
Dan Williams 703eee1610 Merge request !1297 from 'sushrut-branch'
iface-modem-firmware: report new ID's based on PCI SSVID/SSPID

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1297
2025-02-25 18:54:23 +00:00
Sushrut Shree Trivedi 9c63f0acb0 iface-modem-firmware: report new ID's based on PCI SSVID/SSPID
Add new device ID based on PCI SSVID/SSPID to enable
FW download based on the same.

Signed-off-by: Sushrut Shree Trivedi <quic_sushruts@quicinc.com>
2025-02-25 18:43:47 +00:00
Dan Williams 1603c512dd Merge request !1296 from 'cli-fix-call-cbm-opts'
cli: fix Cell Broadcast Message short-path conflict with Call

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1296

Closes #962
2025-02-25 18:38:29 +00:00
Dan Williams 654c59edc0 cli: fix Cell Broadcast Message short-path conflict with Call
They both used 'o', but Call had it first. Change CBM to 'c'.

Fixes: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/962

Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-02-25 18:29:49 +00:00
Dan Williams 61f1000d82 Merge request !1298 from 'dco2'
ci: only run DCO check on merge requests

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1298
2025-02-25 17:02:23 +00:00
Dan Williams 41b1923d71 ci: only run DCO check on merge requests
Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-02-25 10:56:36 -06:00
Dan Williams cd1ba1c0a7 Merge request !1292 from 'dco'
ci: add DCO check action

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1292
2025-02-25 16:30:36 +00:00
Dan Williams ca6a68a280 ci: add DCO check action
Check each commit in an MR for Signed-off-by: Name <email>

Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-02-25 10:19:21 -06:00
Dan Williams 3ea5c84872 Merge request !1293 from 'main'
SIM7600 audio bug fix and sample rate change

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1293
2025-02-24 23:17:07 +00:00
Michał Sułek 3966e1c019 Fixed code formatting 2025-02-24 17:35:47 +01:00
Michał Sułek 602808c0eb Setup variable declared after function call, fixed. 2025-02-24 16:18:55 +00:00
Michał Sułek 60bc733004 Was not compiling due to setup being undefined in call_audio_channel_set 2025-02-24 16:18:55 +00:00
Michał Sułek 9477469db4 Dan Williams changed g_usleep to g_timeout_add 2025-02-24 16:18:55 +00:00
Michał Sułek 31e486d672 Fixed the bug regarding SIM7600 modem family that made USB audio to not turn on.
Added the support for 16kHz sample rate for simtech modems and set it as default if available.
2025-02-24 16:18:55 +00:00
Dan Williams 46d126f505 Merge request !1242 from 'supported_storage_changes_check'
iface-modem-messaging: Validate supported storages

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1242
2025-02-24 14:57:28 +00:00
Akula Susmitha 0d6c9279d3 iface-modem-messaging: Validate supported storages
Check for supported storages before setting default storage.

Signed-off-by: Akula Susmitha <quic_asusmith@quicinc.com>
2025-02-24 14:02:02 +00:00
Dan Williams 7055b94eee Merge request !1295 from 'fix_since_annotation'
cell-broadcast: Fix "Since" annotations

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1295
2025-02-24 14:00:44 +00:00
Evangelos Ribeiro Tzaras dc17a771d7 docs: add missing reference to MMCbmState
Fixes: eda130f3bf

Closes: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/963
2025-02-24 08:06:31 +01:00
Evangelos Ribeiro Tzaras 50759c744c cell-broadcast: Fix "Since" annotations 2025-02-24 08:06:28 +01:00
Dan Williams 93b6e42893 Merge request !1271 from 'generic-sahara-firehose'
broadband-modem: generic Firehose and Sahara support

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1271
2025-02-21 14:12:08 +00:00
Aleksander Morgado 781428ddcd iface-modem-firmware: common logic to check for sahara/firehose tags
The logic will exclusively look for the udev tags reporting
sahara/firehose support in the primary control port of each modem
type.
2025-02-21 14:08:50 +00:00
Aleksander Morgado 93da5e0b93 fibocom: add Sahara/Firehose support for NL668-EAU
Signed-off-by: default avatarLukas Voegl <lvoegl@tdt.de>
2025-02-21 14:08:50 +00:00
Lukas Voegl 155893ea38 broadband-modem: generic Firehose and Sahara support
Allows setting the renamed `ID_MM_QUALCOMM_FIREHOSE` and
`ID_MM_QUALCOMM_SAHARA` environment variables for all devices.

Signed-off-by: Lukas Voegl <lvoegl@tdt.de>
2025-02-21 14:08:50 +00:00
Dan Williams 6e981b61b3 Merge request !1287 from 'sushrut-branch'
kernel-device, generic: add subsystem device ID support

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1287
2025-02-21 14:01:51 +00:00
Sushrut Shree Trivedi 092439369b base-modem: add subsystem device ID property
Subsystem device ID can be used for identifying PCI modems,
so expose the property.

Signed-off-by: Sushrut Shree Trivedi <quic_sushruts@quicinc.com>
2025-02-21 10:39:29 +05:30
Sushrut Shree Trivedi 894b517dae kernel-device, generic: add subsystem device ID support
Add subsystem device ID support, that can be used in pci devices
instead of vendor/device ID customization.

Signed-off-by: Sushrut Shree Trivedi <quic_sushruts@quicinc.com>
2025-02-21 10:39:03 +05:30
Dan Williams 286598388b Merge request !1288 from 'add_dtmf_quectel'
src: plugins: quectel: add DTMF dbus notification support

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1288
2025-02-19 21:23:22 +00:00
Kévin L'hôpital b1e58e0f6e src: plugins: quectel: add DTMF dbus notification support
The quectel modems that are not using QMI could receive DTMF events but
no dbus notification was sent to the user space. This patch adds the
DTMF notification support to the quectel plugin.

Signed-off-by: Kévin L'hôpital <kevin.lhopital@savoirfairelinux.com>
2025-02-19 09:47:28 +01:00
Dan Williams ab59eaee50 Merge request !1268 from 'netlink-getlink'
netlink: add RTM_GETLINK support to read MAC address

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1268
2025-02-19 00:42:33 +00:00
Dan Williams 0a94b0138d netlink: add RTM_GETLINK support to read MAC address
Since we're also now reading responses we need to check sender
credentials to make sure we're talking to the kernel, and not
some other process spoofing netlink.

Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-02-18 21:06:19 +00:00
Dan Williams 029a8cd11a Merge request !1284 from 'example-sms-watch-python'
examples: add sms-watch-python

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1284
2025-02-18 15:59:58 +00:00
Dan Williams c320e50753 examples: add sms-watch-python
Add an example that watches for and prints all SMS messages of
all modems.

Signed-off-by: Dan Williams <dan@ioncontrol.co>
2025-02-17 21:57:33 +00:00
Aleksander Morgado bc7198df8a Merge request !1289 from 'piotrdrag/pl-update-250209'
po: update Polish translation 250209

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1289
2025-02-17 21:46:11 +00:00
Piotr Drąg 5bf0851e50 po: update Polish translation 2025-02-09 15:04:01 +01:00
Dan Williams 6aac8d4201 Merge request !1286 from 'aleksander/fix-assert'
broadband-modem: exit with error if enable() while in unknown state

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1286
2025-02-06 02:42:31 +00:00
Aleksander Morgado ef5fe9b8d5 broadband-modem: prefer explicit return to break
Just to make it explicit that there is no more logic running
afterwards.
2025-02-03 10:21:32 +00:00
Aleksander Morgado 4ce23a9ebd broadband-modem: exit with error if enable() while in unknown state
We should not assert if the modem is flagged as invalid but an
outstanding enabling request is processed. Let's exit gracefully and
let the object get properly disposed afterwards.

   (libc.so.6 - pthread_kill.c: 44)         __pthread_kill_implementation
   (libc.so.6 - raise.c: 26)    raise
   (libc.so.6 - abort.c: 79)    abort
   (libglib-2.0.so.0 - gtestutils.c: 3450)  g_assertion_message
   (libglib-2.0.so.0 - gtestutils.c: 3476)  g_assertion_message_expr
   (ModemManager - mm-broadband-modem.c)    enable
   (ModemManager - mm-iface-modem.c: 2340)  handle_enable_auth_ready
   (libgio-2.0.so.0 - gtask.c: 1309)        g_task_return_now
   (libgio-2.0.so.0 - gtask.c: 1378)        g_task_return
   (ModemManager - mm-base-modem.c: 2011)   lock_after_authorize_ready
   (libgio-2.0.so.0 - gtask.c: 1309)        g_task_return_now
   (libgio-2.0.so.0 - gtask.c: 1378)        g_task_return
   (ModemManager - mm-base-modem.c: 1841)   base_modem_operation_run
   (ModemManager - mm-base-modem.c: 764)    state_operation_ready
   (libgio-2.0.so.0 - gtask.c: 1309)        g_task_return_now
   (libgio-2.0.so.0 - gtask.c: 1323)        complete_in_idle_cb
   (libglib-2.0.so.0 - gmain.c: 3460)       g_main_dispatch
   (libglib-2.0.so.0 - gmain.c: 4200)       g_main_context_dispatch
   (libglib-2.0.so.0 - gmain.c: 4276)       g_main_context_iterate
   (libglib-2.0.so.0 - gmain.c: 4479)       g_main_loop_run
   (ModemManager - main.c: 236) main
   (libc.so.6 - libc_start_call_main.h: 58) __libc_start_call_main
   (libc.so.6 - libc-start.c: 360)          __libc_start_main_impl
   (ModemManager + 0x000b8850)              _start
2025-02-03 10:18:19 +00:00
Dan Williams 0743d88d42 Merge request !1285 from 'dp/fix-err-init'
shared-telit: fix missing error initialization in load_revision_ready

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1285

Closes #953
2025-01-31 15:47:32 +00:00
Daniele Palmas f6c0917a65 shared-telit: fix missing error initialization in load_revision_ready
Closes #953
2025-01-31 16:37:53 +01:00
Dan Williams a5332d260c Merge request !1260 from 'main'
broadband-modem-qmi: retry when "Get Serving System" fails

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1260

Closes #667
2025-01-23 02:58:59 +00:00
Valentin Blot 59d7be3658 broadband-modem-qmi: separate "system info" and "serving system" indications registration
Some modems succeed on enabling "system info" and disabling "serving system" in one
transaction, even though they don't support "system info". This commit separates the
two: first, try to enable "system info", and if it succeeds then disable "serving system".
2025-01-23 02:54:36 +00:00
Dan Williams 35c0556f73 Merge request !1282 from 'fix-its-location'
Specify a path to the ITS rules

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1282
2025-01-23 02:50:04 +00:00
Yegor Yefremov 907f7a2813 Specify a path to the ITS rules
Use our own ITS rules found under data/its. This resolves a
configuration breakage on some systems:

msgfmt: cannot locate ITS rules for data/org.freedesktop.ModemManager1.policy.in

According to the msgfmt manual, we need to specify a path to the parent
directory containing its folder. Hence, we add a path to data as the
data_dirs option.
2025-01-23 02:36:31 +00:00
Dan Williams 4e31b7fdda Merge request !1274 from 'resume-inhibitor-crash'
suspend: support logind not sending PrepareForSleep(true)

https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/merge_requests/1274

Closes #949
2025-01-23 02:35:44 +00:00
Arnav Singh 5eb8203f8e suspend: support logind not sending PrepareForSleep(true)
elogind sends PrepareForSleep(false) when resuming but doesn't necessarily
send PrepareForSleep(true) when sleeping. This means we didn't necessarily
drop our previous inhibitor when it's time to take a new one. So instead of
asserting that we dropped our previous inhibitor, just reuse it.
2025-01-22 08:42:02 -08:00