SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
6,844 Commits 2 Branches 0 Tags
3b35bbd47bc8accd42eed2c22070557104f09d27
Commit Graph
2010 Commits
Author SHA1 Message Date
Aleksander Morgado e623a54d27 quectel: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado d25163cca1 pantech: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 662f8afc56 option,hso: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 4e0a9b1985 novatel: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 793fc1c51a nokia: no logging in plugin 2020-04-08 16:35:09 +02:00
Aleksander Morgado 63955ce52d mtk: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 1edd4bb101 mbm: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 64ac1c19ff longcheer: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 62033b1b6e linktop: no logging in plugin 2020-04-08 16:35:09 +02:00
Aleksander Morgado 2da417c7a2 iridium: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado fe78612d6d icera: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 1cb39536e9 huawei: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 59e6e3b141 haier: no logging in plugin 2020-04-08 16:35:09 +02:00
Aleksander Morgado fb85b5cbf9 generic: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado a5df49c5f4 foxconn: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 77080d5f26 fibocom: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado b3e56bc576 dlink: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 784fd9b740 dell: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 261ba90d08 cinterion: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado fe4b8f6817 anydata: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado f5ce4a722a altair: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado a2b57474dc error-helpers: port to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado ecd766796a modem-helpers: port cesq response parser to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 39dd4c166d modem-helpers: port clcc list parser to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 0f708daf0b modem-helpers: port supported modes filtering to use object logging 2020-04-08 16:35:09 +02:00
Aleksander Morgado 9bcadea172 log: new object logging support 
So that we can provide the specific object id in every log associated
to a given object.
 2020-04-08 16:35:08 +02:00
mozzwald a309b089c9 quectel: add port type hints for EC25/EG25 #194 2020-03-25 12:35:41 -05:00
Aleksander Morgado 6eabfd27bf huawei: only tag GETPORTMODE supported if it was really used 
E.g. do nothing if the response is empty:

 <debug> (ttyUSB1): -->'AT^GETPORTMODE<CR>'
 <debug> (ttyUSB1): <--'<CR><LF>^GETPORTMODE: TYPE: WCDMA: Huawei Technologies Co.,Ltd.,<CR><LF><CR><LF>OK<CR><LF>'
 2020-03-03 17:23:07 +00:00
Aleksander Morgado 353e27065d huawei: try to read port type hints from interface descriptions 
So far, we're really only interested in the "modem" and "pcui" ports.

  root@9d52738:/sys/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.4# find . -name interface|sort
  ./1-1.4:2.0/interface
  ./1-1.4:2.1/interface
  ./1-1.4:2.2/interface
  ./1-1.4:2.3/interface
  ./1-1.4:2.4/interface
  ./1-1.4:2.5/interface
  ./1-1.4:2.6/interface

  root@9d52738:/sys/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.4# find . -name interface|sort|xargs cat
  CDC Ethernet Control Model (ECM)
  CDC Ethernet Data
  Huawei Mobile Connect - Modem
  Huawei Mobile Connect - Application
  Huawei Mobile Connect - Pcui
  Huawei Mobile Connect - Ctrl
  Huawei Mobile Connect - Serial B

Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/170
 2020-03-03 17:23:07 +00:00
Aleksander Morgado 5da33df35b huawei: avoid attempting to complete GTask twice 2020-02-26 13:12:20 +01:00
Aleksander Morgado 00dc961cad iface-modem-location: common helper code to test raw gps 2020-02-07 14:42:16 +00:00
Aleksander Morgado bdd1874f17 tests,keyfiles: add dummy test to avoid -Wunused-function warnings 
If none of the plugins enabled in the build has custom keyfiles, the
common_test() method would be unused. Avoid this just by adding a new
dummy test which is always available in the keyfiles tester.
 2020-02-03 16:08:40 +01:00
Aleksander Morgado 55d344ab96 tests,udev-rules: add dummy test to avoid -Wunused-function warnings 
If none of the plugins enabled in the build has custom udev rules, the
common_test() method would be unused. Avoid this just by adding a new
dummy test which is always available in the udev rules tester.
 2020-02-02 11:33:13 +01:00
Aleksander Morgado 9e24226364 port-probe: MMPortProbeAtCommand always has constant command strings 2020-01-31 15:18:35 +01:00
Aleksander Morgado accd1a5841 base-modem: define new helper MMBaseModemAtCommandAlloc 
It has the same exact format as MMBaseModemAtCommand, but its contents
are assumed heap allocated.

The only real purpose of this type is to allow defining static
constant MMBaseModemAtCommand variables without warnings when using
-Wdiscarded-qualifiers.
 2020-01-31 15:18:35 +01:00
Aleksander Morgado 1bf9937cd5 via: fix warnings with -Wdiscarded-qualifiers 
via/mm-plugin-via.c: In function ‘mm_plugin_create’:
  via/mm-plugin-via.c:59:54: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     59 |     static const mm_str_pair product_strings[] = { { "via",    "cbp7" },
        |                                                      ^~~~~
  via/mm-plugin-via.c:59:64: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     59 |     static const mm_str_pair product_strings[] = { { "via",    "cbp7" },
        |                                                                ^~~~~~
  via/mm-plugin-via.c:60:54: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     60 |                                                    { "fusion", "2770p" },
        |                                                      ^~~~~~~~
  via/mm-plugin-via.c:60:64: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     60 |                                                    { "fusion", "2770p" },
        |                                                                ^~~~~~~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado 4a609e564a ublox: fix disabling of unsolicited events 
The incorrect ready() method was being used while disabling, which
ended up making the parent disable not being run at all.

  ublox/mm-broadband-modem-ublox.c:1178:1: error: ‘voice_disable_unsolicited_events_ready’ defined but not used [-Werror=unused-function]
   1178 | voice_disable_unsolicited_events_ready (MMBroadbandModemUblox *self,
        | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado 72a124a121 ublox: fix warnings with -Wimplicit-fallthrough 
ublox/mm-broadband-modem-ublox.c:458:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    458 |         ctx->step++;
        |         ~~~~~~~~~^~
  ublox/mm-broadband-modem-ublox.c:461:5: note: here
    461 |     case SET_CURRENT_MODES_BANDS_STEP_ACQUIRE:
        |     ^~~~
  ublox/mm-broadband-modem-ublox.c:468:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    468 |         ctx->step++;
        |         ~~~~~~~~~^~
  ublox/mm-broadband-modem-ublox.c:471:5: note: here
    471 |     case SET_CURRENT_MODES_BANDS_STEP_CURRENT_POWER:
        |     ^~~~
  ...
 2020-01-31 15:18:35 +01:00
Aleksander Morgado 3197a52c58 ublox: fix warnings with -Wswitch-enum 
ublox/mm-broadband-modem-ublox.c:1246:5: error: enumeration value ‘MM_CALL_STATE_UNKNOWN’ not handled in switch [-Werror=switch-enum]
   1246 |     switch (call_info.state) {
        |     ^~~~~~
  ublox/mm-broadband-modem-ublox.c:1246:5: error: enumeration value ‘MM_CALL_STATE_ACTIVE’ not handled in switch [-Werror=switch-enum]
  ublox/mm-broadband-modem-ublox.c:1246:5: error: enumeration value ‘MM_CALL_STATE_HELD’ not handled in switch [-Werror=switch-enum]
  ublox/mm-broadband-modem-ublox.c:1246:5: error: enumeration value ‘MM_CALL_STATE_TERMINATED’ not handled in switch [-Werror=switch-enum]
 2020-01-31 15:18:35 +01:00
Aleksander Morgado d6ec29c49e ublox: fix warnings with -Wswitch-default 
ublox/mm-broadband-modem-ublox.c: In function ‘preload_support_config’:
  ublox/mm-broadband-modem-ublox.c:100:5: error: switch missing default case [-Werror=switch-default]
    100 |     switch (self->priv->support_config.method) {
        |     ^~~~~~
  ublox/mm-broadband-modem-ublox.c:112:5: error: switch missing default case [-Werror=switch-default]
    112 |     switch (self->priv->support_config.uact) {
        |     ^~~~~~
  ublox/mm-broadband-modem-ublox.c:123:5: error: switch missing default case [-Werror=switch-default]
    123 |     switch (self->priv->support_config.ubandsel) {
        |     ^~~~~~
  ublox/mm-broadband-modem-ublox.c: In function ‘set_current_modes_bands_step’:
  ublox/mm-broadband-modem-ublox.c:452:5: error: switch missing default case [-Werror=switch-default]
    452 |     switch (ctx->step) {
        |     ^~~~~~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado f66f7458b7 simtech: fix warnings with -Wimplicit-fallthrough 
simtech/mm-broadband-modem-simtech.c: In function ‘enable_unsolicited_events_context_step’:
  simtech/mm-broadband-modem-simtech.c:442:18: error: this statement may fall through [-Werror=implicit-fallthrough=]
    442 |         ctx->step++;
        |         ~~~~~~~~~^~
  simtech/mm-broadband-modem-simtech.c:444:5: note: here
    444 |     case ENABLE_UNSOLICITED_EVENTS_STEP_LAST:
        |     ^~~~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado f6a103ef13 simtech: fix warnings with -Wswitch-default 
simtech/mm-broadband-modem-simtech.c: In function ‘enable_unsolicited_events_context_step’:
  simtech/mm-broadband-modem-simtech.c:378:5: error: switch missing default case [-Werror=switch-default]
    378 |     switch (ctx->step) {
        |     ^~~~~~
  simtech/mm-broadband-modem-simtech.c: In function ‘disable_unsolicited_events_context_step’:
  simtech/mm-broadband-modem-simtech.c:563:5: error: switch missing default case [-Werror=switch-default]
    563 |     switch (ctx->step) {
        |     ^~~~~~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado 7873ef00e9 simtech: fix warnings with -Wsign-compare 
simtech/mm-broadband-modem-simtech.c: In function ‘simtech_act_to_mm_act’:
  simtech/mm-broadband-modem-simtech.c:89:19: error: comparison of integer expressions of different signedness: ‘int’ and ‘long unsigned int’ [-Werror=sign-compare]
     89 |     return (nsmod < G_N_ELEMENTS (simtech_act_to_mm_act_map) ? simtech_act_to_mm_act_map[nsmod] : MM_MODEM_ACCESS_TECHNOLOGY_UNKNOWN);
        |                   ^
 2020-01-31 15:18:35 +01:00
Aleksander Morgado 68f3eeeaa7 option,hso: fix warnings with -Wsign-compare 
option/mm-broadband-bearer-hso.c: In function ‘ip_config_ready’:
  option/mm-broadband-bearer-hso.c:128:21: error: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Werror=sign-compare]
    128 |                 num != ctx->cid) {
        |                     ^~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado fc581c50bd pantech: fix warnings with -Wdiscarded-qualifiers 
pantech/mm-plugin-pantech.c:69:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
      69 |     { "ATE0", 3, port_probe_response_processor_is_pantech_at },
         |       ^~~~~~
   pantech/mm-plugin-pantech.c:70:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
      70 |     { "ATE0", 3, port_probe_response_processor_is_pantech_at },
         |       ^~~~~~
   pantech/mm-plugin-pantech.c:71:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
      71 |     { "ATE0", 3, port_probe_response_processor_is_pantech_at },
         |       ^~~~~~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado f661179310 novatel-lte: fix warnings with -Wdiscarded-qualifiers 
novatel/mm-broadband-modem-novatel-lte.c:249:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
    249 |     { "+CNUM",  3, TRUE, response_processor_cnum_ignore_at_errors },
        |       ^~~~~~~
  novatel/mm-broadband-modem-novatel-lte.c:250:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
    250 |     { "$NWMDN", 3, TRUE, response_processor_nwmdn_ignore_at_errors },
        |       ^~~~~~~~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado f3acdcaa1b mtk: fix warnings with -Wdiscarded-qualifiers 
mtk/mm-broadband-modem-mtk.c:727:6: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
    727 |     {"+ECSQ=2", 5, FALSE, NULL},
        |      ^~~~~~~~~
  mtk/mm-broadband-modem-mtk.c:733:6: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
    733 |     {"+ECSQ=0", 5, FALSE, NULL},
        |      ^~~~~~~~~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado 1f2018d524 nokia: fix warnings with -Wdiscarded-qualifiers 
nokia/mm-plugin-nokia.c:37:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     37 |     { "ATE1 E0", 3, mm_port_probe_response_processor_is_at },
        |       ^~~~~~~~~
  nokia/mm-plugin-nokia.c:38:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     38 |     { "ATE1 E0", 3, mm_port_probe_response_processor_is_at },
        |       ^~~~~~~~~
  nokia/mm-plugin-nokia.c:39:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     39 |     { "ATE1 E0", 3, mm_port_probe_response_processor_is_at },
        |       ^~~~~~~~~
  nokia/mm-plugin-nokia-icera.c:36:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     36 |     { "ATE1 E0", 3, mm_port_probe_response_processor_is_at },
        |       ^~~~~~~~~
  nokia/mm-plugin-nokia-icera.c:37:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     37 |     { "ATE1 E0", 3, mm_port_probe_response_processor_is_at },
        |       ^~~~~~~~~
  nokia/mm-plugin-nokia-icera.c:38:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     38 |     { "ATE1 E0", 3, mm_port_probe_response_processor_is_at },
        |       ^~~~~~~~~
 2020-01-31 15:18:35 +01:00
Aleksander Morgado b5c08a47be mbm: fix warnings with -Wdiscarded-qualifiers 
mbm/mm-broadband-modem-mbm.c:409:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
    409 |     { "&F", 3, FALSE, NULL },
        |       ^~~~
  mbm/mm-broadband-modem-mbm.c:411:7: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
    411 |     { "*ENAP=0", 3, FALSE, NULL },
        |       ^~~~~~~~~
  ...
 2020-01-31 15:18:35 +01:00
Aleksander Morgado 40497a3904 iridium: fix warnings with -Wdiscarded-qualifiers 
iridium/mm-plugin-iridium.c: In function ‘mm_plugin_create’:
  iridium/mm-plugin-iridium.c:64:52: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     64 |     static const mm_str_pair product_strings[] = {{"motorola", "satellite" },
        |                                                    ^~~~~~~~~~
  iridium/mm-plugin-iridium.c:64:64: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
     64 |     static const mm_str_pair product_strings[] = {{"motorola", "satellite" },
        |                                                                ^~~~~~~~~~~
 2020-01-31 15:18:35 +01:00