0.7 hasn't used spaces for over a year, so this is a pretty safe
change. Some modems just don't like it.
0.7 commit to remove spaces:
commit 0265bfe52dcc93372aff6064e849044ccb72aa1e
Author: Dan Williams <dcbw@redhat.com>
Date: Fri Oct 24 15:15:06 2008 +0000
2008-10-24 Dan Williams <dcbw@redhat.com>
* src/nm-gsm-device.c
- (set_apn): remove erroneous spaces in AT+CGDCONT command (Jerone Young)
gcc will interpret the constant value as a uint32 but
the port's set_property() was taking it as a uint64. Thus
the top 32 bits were probably garbage, and messed up
on big-endian architectures leading to random large
probe delays.
The standard dictates CSQ response strength value to be [0 - 31]
inclusive, and 99 means "unknown" or "no service". Make that
apparent and don't treat 99 as 99% which it clearly isn't. Also,
allow spaces in the CSQ response.
Phones especially don't seem to consistently implement this. For now,
we'll hack it out, but later, we'll want to have a class method for
power-on instead of just a property so that subclasses can decided for
themselves (since they know their hardware better) whether failure
of the power-on command is fatal or not.
Full references prevented destruction of the modem object if
it was unplugged or somehow removed. To fix that using full
references on the modems would require that all usage of
MMCallbackInfo to be aware of the validity of the modem and to
ensure the callback was called whenever the modem became invalid.
That, needless to say, would suck. Since any in-progress calls
can't complete when the modem is invalid anyway, just have the
MMCallbackInfo object return a generic error when the modem goes
away and the call is still in-progress.
Like UMTS vs. GSM, EVDO and 1x are separate networks and technologies
and have separate registration state. You can even be roaming on
EVDO while in your home 1x network. Handle that.
rfcomm devices seem to be created as 'virtual' devices first, without
any parents, then moved to the right place in the device tree. So
handle moves too; if the modem was already found in the 'add' phase
it'll be ignored in the move phase.
Two hacks here:
1) rfcomm ports don't have an easily accessible driver name, so we just
match the parent's subsystem to 'bluetooth' and use that
2) libgudev doesn't seem be be able to get the rfcomm device's device file,
which would normally be /dev/rfcommX. Oh well, we don't use the device file
yet anyway
It's only relevant when the port is open anyway, and marking the port
disconnected in nm_serial_port_close(), which used to be called from
the finalize() function, would trigger the notifier when stuff was
already cleaned up. So move the nm_serial_port_close() call to
dispose() and remove the connected notifier before we clean the
port up.
Previously, a few operations (like disable) could trigger a modem
flash in parallel with another flash. That's wrong, don't allow
that. At the same time, add in finer-grained error checking on
serial port speed operations, and fix a GSM generic bug that would
send the POWER_UP string on disable.
Like the Sanyo SCP-3800 (Sprint Katana LX). Make up your freakin'
mind people, either prefix *all* responses with the command stem,
or don't. But just pick one dammit.
Jeroen Elebaut
Dan Williams
Alexander Sack
Noel J. Bergman
Bryan Duff