SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,289 Commits 2 Branches 0 Tags
cd5e22841aa72aba9c7bf642efcaacc0622d00ec
Commit Graph
13 Commits
Author SHA1 Message Date
Aleksander Morgado 74fc5baca2 core: port GRegex/GMatchInfo to use autoptr() 
The behavior of GRegex changed in 2.73.2 once it was ported from pcre1
to pcre2. In some cases it was made more strict, which is fine, in
other cases it exposed some change in how it behaves on certain
matches that is not extremely clear whether it's ok or not.

See https://gitlab.gnome.org/GNOME/glib/-/issues/2729
See https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/601
See https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/621

Either way, one thing that was assumed was that initializing all
GRegex/GMatchInfo variables to NULL and making sure they're NULL
before they're initialized by glib (especially the GMatchInfo) was a
good and safer approach.

So, whenever possible, g_autoptr() is used to cleanup the allocated
GMatchInfo/GRegex variables, and otherwise, g_clear_pointer() is used
to ensure that no free/unref is attempted unless the given variable is
not NULL, and also so that the variable is reseted to NULL after being
disposed.
 2022-09-05 17:33:11 +00:00
Aleksander Morgado 5d176a1e61 base-modem: explicitly say if NET or TTY data ports are supported 
A modem that creates exclusively bearer objects that work with NET
ports (e.g. all QMI or MBIM modems) must not add any TTY port in the
list of data ports.

A modem that creates exclusively bearer objects that work with TTY
ports (e.g. the generic modem) must not add any NET port in the
list of data ports.

A modem that may use both TTY and NET ports should add all in the list
of data ports.

Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/324
Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/329
 2021-03-04 18:03:28 +01:00
Aleksander Morgado fe4b8f6817 anydata: port to use object logging 2020-04-08 16:35:09 +02:00
Ben Chan 47cdad55a8 anydata: port get_detailed_registration_state to use GTask 2017-10-20 09:44:56 +02:00
Ben Chan bee3f063b4 anydata: remove unused 'port' field in DetailedRegistrationStateContext 
The 'port' field in DetailedRegistrationStateContext is initialized to
NULL but never updated or used.

When detailed_registration_state_context_complete_and_free() calls
g_object_unref() on the NULL 'port' field, an assertion is raised.
 2017-10-07 10:02:35 +02:00
Aleksander Morgado 2eb55d3224 plugins: use G_N_ELEMENTS when iterating ports array 2017-05-30 17:28:23 +02:00
Aleksander Morgado 6f235b9948 ports: rename 'MMAtSerialPort' to 'MMPortSerialAt' 2014-02-13 13:40:01 +01:00
Aleksander Morgado 0436b3e457 api,introspection: report list of drivers, not just one 
Different ports of the same modem may get handled by different drivers. We
therefore need to provide a list of drivers (new `Modem.Drivers' property with
signature 'as') instead of just one (removed `Modem.Driver' property with
signature 's').

$ sudo mmcli -m 0 | grep drivers
           |        drivers: 'qcserial, qmi_wwan'
 2012-08-24 13:34:51 +02:00
Aleksander Morgado 58f21a6d94 anydata: ignore several unsolicited messages 2012-03-18 17:28:15 +01:00
Aleksander Morgado ffee914197 anydata: implement modem reset 2012-03-18 17:28:15 +01:00
Aleksander Morgado 82d72744a2 anydata: get detailed CDMA1x/EVDO registration states 2012-03-18 17:28:14 +01:00
Aleksander Morgado d58d3f52a2 anydata: don't get serving system with +CSS? 2012-03-18 17:28:14 +01:00
Aleksander Morgado 75c38941a8 anydata: start porting the AnyDATA plugin 2012-03-18 17:28:14 +01:00