Ben Chan
ec14a26a7d
broadband-modem-mbim: port messaging_load_supported_storages to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
5bf0af7a83
broadband-modem-mbim: port messaging_check_support to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
cc71743e26
broadband-modem-mbim: port modem_3gpp_load_imei to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
5b0b3f326e
broadband-modem-mbim: port modem_3gpp_load_operator_code to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
9401aa70e5
broadband-modem-mbim: port modem_3gpp_load_operator_name to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
fb38601ef4
broadband-modem-mbim: port modem_load_supported_ip_families to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
99bb49d814
broadband-modem-mbim: port modem_load_supported_modes to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
df0049d1c2
broadband-modem-mbim: port modem_load_device_identifier to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
43aaa92ee1
broadband-modem-mbim: port modem_load_equipment_identifier to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
fb9c758f05
broadband-modem-mbim: port modem_load_revision to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
234d7810f5
broadband-modem-mbim: port modem_load_model to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
6cf6eeb0aa
broadband-modem-mbim: port modem_load_manufacturer to use GTask
2017-07-11 10:30:39 -07:00
Ben Chan
3a789c0de7
bearer-qmi: replace g_new + memcpy with g_memdup
2017-07-11 11:36:53 +02:00
Ben Chan
627ef274df
plugin: check error returned by g_task_propagate_error instead
...
mm_plugin_supports_port_finish directly casts the value returned by
g_task_propagate_int to MMPluginSupportsResult enum value, which
implicitly assumes MM_PLUGIN_SUPPORTS_PORT_UNKNOWN equals to -1.
Instead of relying on such an implicit assumption, this patch modifies
the code to check if the GError argument to g_task_propagate_error is
populated instead.
2017-07-07 10:23:46 +02:00
Ben Chan
a36347eff7
broadband-bearer: check error returned by g_task_propagate_error instead
...
When returning an enum value via g_task_return_int, some code assumes
the enum value is always non-negative and thus considers that a negative
value implies an error. This assumption could be invalidated if a
negative value is later added to the enum. To make it less error prone
to future changes, this patch modifies the code to check if the GError
argument to g_task_propagate_error is populated instead.
2017-07-07 10:23:46 +02:00
Ben Chan
22e5b216cb
broadband-modem: remove unnecessary G_TYPE_CHECK_INSTANCE_CAST calls
...
This patch removes unnecessary G_TYPE_CHECK_INSTANCE_CAST calls on any
instance that is already of the type being casted to.
2017-07-07 10:16:55 +02:00
Aleksander Morgado
b44f1b6da0
base-call: port mm_base_call_delete to use GTask
2017-07-06 11:16:37 +02:00
Aleksander Morgado
da45d0c5b2
base-call: minor coding style fixes
2017-07-06 11:11:20 +02:00
Aleksander Morgado
4e5ad5585a
base-call: no need to keep a modem reference around
...
The mm_base_modem_at_command() async calls keep a modem reference
valid for as long as the operation and its completion handler are run,
so there really is no need for the caller (the call operation) to keep
a reference to the modem object itself.
2017-07-06 10:59:09 +02:00
Ben Chan
2ffcd93ebb
base-call: port call_delete to use GTask
2017-07-06 10:51:48 +02:00
Ben Chan
f9ddfd7aa4
base-call: port call_send_dtmf_ready to use GTask
2017-07-06 10:51:48 +02:00
Ben Chan
3659ada7d9
base-call: port call_hangup to use GTask
2017-07-06 10:51:48 +02:00
Ben Chan
c5232ffe41
base-call: port call_accept to use GTask
2017-07-06 10:51:48 +02:00
Ben Chan
76b3ad41fe
base-call: port call_start to use GTask
2017-07-06 10:51:48 +02:00
Ben Chan
d56621b9a1
iface-modem: check error returned by g_task_propagate_error instead
...
When returning an enum value via g_task_return_int, some code assumes
the enum value is always non-negative and thus considers that a negative
value implies an error. This assumption could be invalidated if a
negative value is later added to the enum. To make it less error prone
to future changes, this patch modifies the code to check if the GError
argument to g_task_propagate_error is populated instead.
2017-07-06 10:50:27 +02:00
Ben Chan
ba3a7f0c69
port-serial-qcdm: port mm_port_serial_qcdm_command to use GTask
2017-07-05 10:48:49 +02:00
Ben Chan
75aebc71c7
base-sim: port mm_base_sim_send_{pin,puk} to use GTask
2017-07-05 10:42:41 +02:00
Ben Chan
bc51c8c474
base-sim: port load_* to use GTask
...
This patch ports the following functions to use GTask:
- load_imsi
- load_operator_identifier
- load_operator_name
- load_sim_identifier
2017-07-05 10:42:41 +02:00
Ben Chan
b99f9e3b0c
base-sim: port mm_base_sim_initialize to use GTask
2017-07-05 10:42:41 +02:00
Ben Chan
d085cb2b96
base-sim: port send_pin and send_puk to use GTask
2017-07-05 10:42:41 +02:00
Ben Chan
650d271350
base-sim: port enable_pin to use GTask
2017-07-05 10:42:41 +02:00
Ben Chan
12d578ff85
base-sim: port change_pin to use GTask
2017-07-05 10:42:41 +02:00
Ben Chan
87176cf52c
base-sms: port mm_base_sms_delete to use GTask
2017-07-03 10:48:34 +02:00
Ben Chan
03c86a9db8
base-sms: port sms_delete to use GTask
2017-07-03 10:48:34 +02:00
Ben Chan
c5be9aad97
base-sms: port sms_send to use GTask
2017-07-03 10:48:34 +02:00
Ben Chan
4902d9d759
base-sms: port sms_store to use GTask
2017-07-03 10:48:34 +02:00
Ben Chan
1f4cd9ac91
base-bearer: port mm_base_bearer_disconnect to use GTask
2017-07-03 10:42:57 +02:00
Ben Chan
98f4fe2f85
base-bearer: port mm_base_bearer_connect to use GTask
2017-07-03 10:42:57 +02:00
Ben Chan
0efc3cf908
bearer-qmi: port reload_stats to use GTask
2017-07-03 10:33:44 +02:00
Ben Chan
9efc2f7050
bearer-qmi: port disconnect to use GTask
2017-07-03 10:33:43 +02:00
Ben Chan
a6547642ed
bearer-qmi: port _connect to use GTask
2017-07-03 10:33:43 +02:00
Ben Chan
dfcffbae04
base-sim: remove unused wait_for_unlock_id in SendPinPukContext
...
Commit d27e40ae9 ("core: new `Initializing' state in the global modem
state machine") added a 'wait_for_unlock_id' field to SendPinPukContext,
but never actually set it up.
2017-07-03 10:29:06 +02:00
Ben Chan
524acd7596
iface-modem: use g_new0 instead of g_slice_new0 to allocate context
...
By using g_new0 instead of g_slice_new0 to allocate certain context
structs, we can simply use g_free as GDestroyNotify in
g_task_set_task_data and get rid of those functions that solely wrap the
g_slice_free call.
2017-06-30 15:33:03 +02:00
Ben Chan
d49cf585dd
bearer-mbim: port MMBearerMbim to use GTask
2017-06-30 15:33:03 +02:00
Ben Chan
347610a63d
iface-modem: port mm_iface_modem_wait_for_final_state to use GTask
2017-06-30 14:08:08 +02:00
Ben Chan
7d197d10bd
iface-modem: port internal_load_unlock_required to use GTask
2017-06-30 12:00:09 +02:00
Ben Chan
4df5458847
iface-modem: port mm_iface_modem_update_lock_info to use GTask
2017-06-30 12:00:09 +02:00
Ben Chan
ebc20e7948
iface-modem: port mm_iface_modem_set_power_state to use GTask
2017-06-30 12:00:09 +02:00
Ben Chan
25f0d42089
iface-modem: port mm_iface_modem_set_current_modes to use GTask
2017-06-30 12:00:09 +02:00
Ben Chan
71dd152dbe
iface-modem: port mm_iface_modem_set_current_bands to use GTask
2017-06-30 12:00:09 +02:00