SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
fd052c8e584a41efc211690e993f6ef0ee3092ac
ModemManager/src
T
History
Aleksander Morgado fd052c8e58 base-sim: don't allow sending PIN/PUK if not required 
This avoids issues when e.g. sending SIM-PIN while the modem is
already unlocked or when SIM-PIN is not enabled.

Under those conditions, the needlessly sent SIM-PIN unlock attempt may
fail while libmm-glib/mmcli reports a successful operation. E.g.:

  # mmcli --sim=/org/freedesktop/ModemManager1/SIM/0 --pin=3497
  successfully sent PIN code to the SIM

But in reality...

  Wed Nov 20 14:38:52 2019 daemon.debug [4254]: <debug> [1574260732.489513] Verifying PIN...
  Wed Nov 20 14:38:52 2019 daemon.debug [4254]: [/dev/cdc-wdm0] sent message...
  <<<<<< RAW:
  <<<<<<   length = 27
  <<<<<<   data   = 01:1A:00:00:0B:02:00:09:00:26:00:0E:00:02:06:00:01:04:33:34:39:37:01:02:00:06:00
  Wed Nov 20 14:38:52 2019 daemon.debug [4254]: [/dev/cdc-wdm0] sent generic request (translated)...
  <<<<<< QMUX:
  <<<<<<   length  = 26
  <<<<<<   flags   = 0x00
  <<<<<<   service = "uim"
  <<<<<<   client  = 2
  <<<<<< QMI:
  <<<<<<   flags       = "none"
  <<<<<<   transaction = 9
  <<<<<<   tlv_length  = 14
  <<<<<<   message     = "Verify PIN" (0x0026)
  <<<<<< TLV:
  <<<<<<   type       = "Info" (0x02)
  <<<<<<   length     = 6
  <<<<<<   value      = 01:04:33:34:39:37
  <<<<<<   translated = [ pin_id = 'pin1' pin_value = '3497' ]
  Wed Nov 20 14:38:52 2019 daemon.debug [4254]: [/dev/cdc-wdm0] received message...
  <<<<<< RAW:
  <<<<<<   length = 30
  <<<<<<   data   = 01:1D:00:80:0B:02:02:09:00:26:00:11:00:02:04:00:01:00:52:00:13:02:00:69:84:10:02:00:03:0A
  Wed Nov 20 14:38:52 2019 daemon.debug [4254]: [/dev/cdc-wdm0] received generic response (translated)...
  <<<<<< QMUX:
  <<<<<<   length  = 29
  <<<<<<   flags   = 0x80
  <<<<<<   service = "uim"
  <<<<<<   client  = 2
  <<<<<< QMI:
  <<<<<<   flags       = "response"
  <<<<<<   transaction = 9
  <<<<<<   tlv_length  = 17
  <<<<<<   message     = "Verify PIN" (0x0026)
  <<<<<< TLV:
  <<<<<<   type       = "Result" (0x02)
  <<<<<<   length     = 4
  <<<<<<   value      = 01:00:52:00
  <<<<<<   translated = FAILURE: AccessDenied

As we already know what the current lock status is, just abort the
user operation if the unlock operation isn't required.
2020-02-12 09:41:10 +00:00
..
kerneldevice
kernel-device-udev: fix warnings with -Wshadow
2020-01-31 14:52:49 +01:00
tests
test-error-helpers: fix warnings with -Wsign-compare
2020-01-31 14:52:49 +01:00
77-mm-pcmcia-device-blacklist.rules
udev: repurpose ID_MM_DEVICE_IGNORE and new MM_FILTER_RULE_EXPLICIT_BLACKLIST
2019-08-29 20:07:03 +00:00
77-mm-usb-device-blacklist.rules
udev: repurpose ID_MM_DEVICE_IGNORE and new MM_FILTER_RULE_EXPLICIT_BLACKLIST
2019-08-29 20:07:03 +00:00
77-mm-usb-serial-adapters-greylist.rules
udev: rename ID_MM_DEVICE_MANUAL_SCAN_ONLY to ID_MM_TTY_MANUAL_SCAN_ONLY
2019-08-29 20:07:03 +00:00
80-mm-candidate.rules
udev: add tags also on bind action
2018-06-02 16:54:37 +02:00
main.c
daemon: register G_IO_ERROR_CANCELLED as "Cancelled" in DBus
2019-10-11 07:27:59 +00:00
Makefile.am
build: use AX_IS_RELEASE() and AX_COMPILER_FLAGS()
2020-01-30 11:59:14 +01:00
mm-auth-provider.c
auth-provider: refactor and simplify
2020-01-23 11:50:23 +00:00
mm-auth-provider.h
auth-provider: refactor and simplify
2020-01-23 11:50:23 +00:00
mm-base-bearer.c
core,base-bearer: fix warnings with -Wswitch-default
2020-01-30 11:59:14 +01:00
mm-base-bearer.h
base-bearer: fix typo in 'bearer-default-ip-family' property name
2017-03-28 22:46:35 +02:00
mm-base-call.c
base-call: do not require primary port to start a call
2019-12-05 15:45:38 +01:00
mm-base-call.h
base-call: catch terminated errors before ATD replies
2019-10-17 08:31:46 +00:00
mm-base-manager.c
auth-provider: fix reference count in manager and modem objects
2020-01-28 10:33:50 +01:00
mm-base-manager.h
filter: allow selection of filter policy on startup
2017-12-05 10:58:29 +01:00
mm-base-modem-at.c
base-modem: define new helper MMBaseModemAtCommandAlloc
2020-01-31 15:18:35 +01:00
mm-base-modem-at.h
base-modem: define new helper MMBaseModemAtCommandAlloc
2020-01-31 15:18:35 +01:00
mm-base-modem.c
base-modem: fix warnings with -Wswitch-enum
2020-01-30 11:59:14 +01:00
mm-base-modem.h
auth-provider: refactor and simplify
2020-01-23 11:50:23 +00:00
mm-base-sim.c
base-sim: don't allow sending PIN/PUK if not required
2020-02-12 09:41:10 +00:00
mm-base-sim.h
call: disallow non-emergency calls when in emergency-only state
2019-10-17 10:51:50 +02:00
mm-base-sms.c
base-sms: fix warnings with -Wshadow
2020-01-30 11:59:14 +01:00
mm-base-sms.h
*: Spelling fixes
2018-01-25 09:52:12 +01:00
mm-bearer-list.c
bearer-list: fix warnings with -Wshadow
2020-01-30 11:59:14 +01:00
mm-bearer-list.h
iface-modem: explicitly disconnect bearer before removing it
2015-12-03 12:01:14 +01:00
mm-bearer-mbim.c
bearer-mbim: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:15 +01:00
mm-bearer-mbim.h
bearer: rename 'MMBearer' to 'MMBaseBearer'
2014-07-06 16:55:29 +02:00
mm-bearer-qmi.c
bearer-qmi: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-bearer-qmi.h
bearer-qmi: decide IP method during connection attempt
2016-07-15 19:31:45 +02:00
mm-broadband-bearer.c
core,broadband-bearer: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-broadband-bearer.h
broadband-bearer: once connected, set flow control settings
2017-04-18 18:08:57 +02:00
mm-broadband-modem-mbim.c
helpers: new macro to CLAMP high threshold only
2020-01-31 15:18:35 +01:00
mm-broadband-modem-mbim.h
core: minor coding style fixes
2014-05-20 09:32:29 +02:00
mm-broadband-modem-qmi.c
broadband-modem-qmi,helpers-qmi: add missing 5GNR access tech enums
2020-01-31 14:52:49 +01:00
mm-broadband-modem-qmi.h
broadband-modem-qmi: implement signal quality loading using QMI
2012-08-29 17:26:42 +02:00
mm-broadband-modem.c
broadband-modem: add optional extra carriage return to in-call URC regex
2020-02-06 15:16:46 +00:00
mm-broadband-modem.h
broadband-modem: allow disabling +CIND URC setup
2019-10-11 09:24:22 +00:00
mm-call-list.c
call-list: allow getting call object by DBus path
2019-07-11 23:21:00 +02:00
mm-call-list.h
call-list: allow getting call object by DBus path
2019-07-11 23:21:00 +02:00
mm-charsets.c
charsets: fix warnings with -Wswitch-default
2020-01-31 14:52:49 +01:00
mm-charsets.h
charsets: new helper to convert binary input data to UTF-8
2018-08-21 16:50:15 +00:00
mm-context.c
build: bump copyright years to 2020
2020-01-03 20:43:45 +01:00
mm-context.h
filter: allow selection of filter policy on startup
2017-12-05 10:58:29 +01:00
mm-device.c
device: don't reprobe if device is gone
2020-01-06 20:46:06 +00:00
mm-device.h
device: keep reference to object manager server
2020-01-06 20:46:06 +00:00
mm-error-helpers.c
core,error-helpers: add missing ME error codes
2019-12-17 10:52:13 +01:00
mm-error-helpers.h
api: only allow including `ModemManager.h' directly
2012-10-04 10:17:13 +02:00
mm-filter.c
filter: update plugin whitelist logic to use 'allowed product ids'
2019-09-11 18:01:50 +00:00
mm-filter.h
filter: update plugin whitelist logic to use 'allowed product ids'
2019-09-11 18:01:50 +00:00
mm-iface-modem-3gpp-ussd.c
iface-modem-3gpp-ussd: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-iface-modem-3gpp-ussd.h
iface-modem-3gpp-ussd: new helper to get current state
2018-08-21 16:50:15 +00:00
mm-iface-modem-3gpp.c
iface-modem-3gpp: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-iface-modem-3gpp.h
iface-modem-3gpp: forced registration is not state
2020-01-06 20:17:08 +00:00
mm-iface-modem-cdma.c
iface-modem-cdma: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-iface-modem-cdma.h
ports: rename 'MMAtSerialPort' to 'MMPortSerialAt'
2014-02-13 13:40:01 +01:00
mm-iface-modem-firmware.c
iface-modem-firmware: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-iface-modem-firmware.h
iface-modem-firmware: make the interface always available
2019-01-03 18:53:52 +00:00
mm-iface-modem-location.c
iface-modem-location: common helper code to test raw gps
2020-02-07 14:42:16 +00:00
mm-iface-modem-location.h
iface-modem-location: allow enabling unmanaged gps even if raw/nmea enabled
2019-04-02 08:40:26 +00:00
mm-iface-modem-messaging.c
iface-modem-messaging: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-iface-modem-messaging.h
broadband-modem: fix +CPMS empty parameter support
2016-03-09 14:43:08 +01:00
mm-iface-modem-oma.c
iface-modem-oma: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-iface-modem-oma.h
ifaces: always include <libmm-glib.h>
2014-07-01 15:42:21 +02:00
mm-iface-modem-signal.c
iface-modem-signal: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-iface-modem-signal.h
iface-modem-signal: use the new 'MMSignal' in the interface implementation
2013-08-21 12:34:54 +02:00
mm-iface-modem-simple.c
iface-modem-simple: don't abort connection attempt if SIM-PUK2 locked
2020-02-12 09:41:10 +00:00
mm-iface-modem-simple.h
iface-modem-simple: implement GetStatus()
2012-03-15 14:14:39 +01:00
mm-iface-modem-time.c
iface-modem-time: fix warnings with -Wimplicit-fallthrough
2020-01-30 11:59:14 +01:00
mm-iface-modem-time.h
iface-modem-time: allow updating network timezone via URCs
2019-07-11 23:21:00 +02:00
mm-iface-modem-voice.c
iface-modem-voice: report calls only if +CLCC was successful
2020-02-06 15:16:46 +00:00
mm-iface-modem-voice.h
call: disallow non-emergency calls when in emergency-only state
2019-10-17 10:51:50 +02:00
mm-iface-modem.c
iface-modem: allow loading current required lock info
2020-02-12 09:41:10 +00:00
mm-iface-modem.h
iface-modem: allow loading current required lock info
2020-02-12 09:41:10 +00:00
mm-log.c
core,log: fix warnings with -Wswitch-enum
2020-01-30 11:59:14 +01:00
mm-log.h
log: Add support for journal logging
2017-06-21 13:08:17 +02:00
mm-modem-helpers-mbim.c
modem-helpers-mbim: fix warnings with -Wswitch-enum
2020-01-31 14:52:49 +01:00
mm-modem-helpers-mbim.h
helpers-mbim: new method to convert IP type settings to/from MM
2018-12-07 16:20:53 +00:00
mm-modem-helpers-qmi.c
broadband-modem-qmi,helpers-qmi: add missing 5GNR access tech enums
2020-01-31 14:52:49 +01:00
mm-modem-helpers-qmi.h
broadband-modem-qmi: prefer ASCII unique IDs
2019-10-11 08:16:04 +00:00
mm-modem-helpers.c
modem-helpers: fix warnings with -Wswitch-enum
2020-01-31 14:52:49 +01:00
mm-modem-helpers.h
helpers: new macro to CLAMP high threshold only
2020-01-31 15:18:35 +01:00
mm-plugin-manager.c
core,plugin-manager: fix warnings with -Wswitch-default
2020-01-30 11:59:14 +01:00
mm-plugin-manager.h
filter: additional strict rules when all device ports available
2017-12-05 10:58:29 +01:00
mm-plugin.c
plugin: fix warnings with -Wdiscarded-qualifiers
2020-01-30 11:59:14 +01:00
mm-plugin.h
filter: update plugin whitelist logic to use 'allowed product ids'
2019-09-11 18:01:50 +00:00
mm-port-mbim.c
port-mbim: use qmi_device_close_async()
2020-01-22 13:15:08 +01:00
mm-port-mbim.h
mbim: fix inconsistency in WITH_QMI guards
2018-08-23 09:44:28 +02:00
mm-port-probe-at.c
port-probe: add a new serial parser filter to detect non-AT strings
2013-04-04 19:26:51 +02:00
mm-port-probe-at.h
port-probe: MMPortProbeAtCommand always has constant command strings
2020-01-31 15:18:35 +01:00
mm-port-probe.c
port-probe: MMPortProbeAtCommand always has constant command strings
2020-01-31 15:18:35 +01:00
mm-port-probe.h
port-probe: support probing for Intel XMM capabilities
2018-08-21 17:02:39 +00:00
mm-port-qmi.c
port-qmi: fallback to raw-ip if WDA Get Data Format requests arguments
2020-02-01 12:52:30 +01:00
mm-port-qmi.h
port-qmi: asynchronous close operation always
2020-01-22 13:56:59 +01:00
mm-port-serial-at.c
port-serial-at: raw commands always run next
2019-06-03 03:50:22 +00:00
mm-port-serial-at.h
port-serial-at: allow specifying subsystem when creating a 'MMPortSerialAt'
2014-02-13 13:40:55 +01:00
mm-port-serial-gps.c
port-serial: rework response parsing
2016-01-23 11:19:19 +01:00
mm-port-serial-gps.h
ports: rename 'MMGpsSerialPort' to 'MMPortSerialGps'
2014-02-13 13:39:54 +01:00
mm-port-serial-qcdm.c
port-serial-qcdm: rewrite condition to make it more readable
2020-01-31 15:18:35 +01:00
mm-port-serial-qcdm.h
broadband-modem/libqcdm: add signal strength from QCDM EVDO Pilot Sets log messages
2016-07-27 10:44:43 -05:00
mm-port-serial.c
port-serial: fix warnings with -Wimplicit-fallthrough
2020-01-30 19:09:52 +01:00
mm-port-serial.h
port-serial: allow deciding whether the command is queued last or run next
2019-06-03 03:50:22 +00:00
mm-port.c
core: use the kernel device object in the port object and the plugin interface
2016-09-29 15:43:05 +02:00
mm-port.h
core: allow flagging ports as 'audio'
2019-10-15 13:19:10 +02:00
mm-private-boxed-types.c
core: new `MMAsyncMethod' boxed type
2012-08-06 20:06:46 +02:00
mm-private-boxed-types.h
core: new `MMAsyncMethod' boxed type
2012-08-06 20:06:46 +02:00
mm-serial-parsers.c
serial-parsers: plug memleak
2013-06-25 11:48:43 +02:00
mm-serial-parsers.h
serial-parsers: allow specifying a custom response filter
2013-04-04 19:26:51 +02:00
mm-shared-qmi.c
shared-qmi: fix warnings with -Wswitch-enum
2020-01-30 11:59:14 +01:00
mm-shared-qmi.h
api,modem: new 'CarrierConfigurationRevision' property
2019-04-02 12:14:03 +02:00
mm-shared.h
plugin-manager: dynamically load 'shared' util libraries
2019-11-27 10:11:43 +00:00
mm-sim-mbim.c
sim-mbim: update unlock retries information after PIN operations
2017-09-07 19:06:55 +02:00
mm-sim-mbim.h
sim: rename 'MMSim' to 'MMBaseSim'
2014-07-06 16:55:29 +02:00
mm-sim-qmi.c
sim-qmi: avoid using deprecated libqmi declarations
2020-01-31 14:52:49 +01:00
mm-sim-qmi.h
qmi: just one InvalidCommand error is enough to avoid all DMS UIM commands
2016-02-11 10:52:09 +01:00
mm-sleep-monitor.c
build: rename sleep monitor source file, only one implementation available
2016-03-21 23:48:46 +01:00
mm-sleep-monitor.h
suspend: imported suspend/resume support from NetworkManager
2015-02-07 12:57:48 +01:00
mm-sms-list.c
sms-list: improve logging of multipart related fields
2019-07-15 13:42:45 +02:00
mm-sms-list.h
sms: rename 'MMSms' to 'MMBaseSms'
2014-07-06 16:55:29 +02:00
mm-sms-mbim.c
sms-mbim: fix peek_device to use g_task_report_new_error
2017-07-18 10:33:00 +02:00
mm-sms-mbim.h
sms: rename 'MMSms' to 'MMBaseSms'
2014-07-06 16:55:29 +02:00
mm-sms-part-3gpp.c
sms-part-3gpp: fix warnings with -Wswitch-enum
2020-01-31 14:52:49 +01:00
mm-sms-part-3gpp.h
libhelpers: include MMSmsEncoding in helper enums generation
2017-12-18 10:33:46 +01:00
mm-sms-part-cdma.c
sms-part-cdma: fix warnings with -Wswitch-default
2020-01-31 14:52:49 +01:00
mm-sms-part-cdma.h
libhelpers: include MMSmsEncoding in helper enums generation
2017-12-18 10:33:46 +01:00
mm-sms-part.c
sms-part: handle CDMA teleservice ID and service category
2013-10-25 19:47:18 +02:00
mm-sms-part.h
libhelpers: include MMSmsEncoding in helper enums generation
2017-12-18 10:33:46 +01:00
mm-sms-qmi.c
sms-qmi: port MMSmsQmi to use GTask
2017-06-30 11:58:53 +02:00
mm-sms-qmi.h
sms: rename 'MMSms' to 'MMBaseSms'
2014-07-06 16:55:29 +02:00
mm-utils.h
utils: fix warnings with -Wredundant-decls
2020-01-30 11:59:14 +01:00