From 3b3deddb546b67a671a09fd75b4d9ec5e09148c9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Guido=20G=C3=BCnther?= <agx@sigxcpu.org>
Date: Wed, 16 Sep 2020 14:51:23 +0200
Subject: [PATCH] debian: Don't abuse the video group

Use a separate group for users that should be able to access
the LED devices.
---
 debian/feedbackd.postinst | 42 +++++++++++++++++++++++++++++++++++++++
 debian/feedbackd.udev     |  6 +++---
 2 files changed, 45 insertions(+), 3 deletions(-)
 create mode 100644 debian/feedbackd.postinst

diff --git a/debian/feedbackd.postinst b/debian/feedbackd.postinst
new file mode 100644
index 0000000..b6a2dbc
--- /dev/null
+++ b/debian/feedbackd.postinst
@@ -0,0 +1,42 @@
+#!/bin/sh
+# postinst script for feedbackd
+#
+# see: dh_installdeb(1)
+
+set -e
+
+# summary of how this script can be called:
+#        * <postinst> `configure' <most-recently-configured-version>
+#        * <old-postinst> `abort-upgrade' <new version>
+#        * <conflictor's-postinst> `abort-remove' `in-favour' <package>
+#          <new-version>
+#        * <postinst> `abort-remove'
+#        * <deconfigured's-postinst> `abort-deconfigure' `in-favour'
+#          <failed-install-package> <version> `removing'
+#          <conflicting-package> <version>
+# for details, see https://www.debian.org/doc/debian-policy/ or
+# the debian-policy package
+
+case "$1" in
+    configure)
+        if ! getent group feedbackd >/dev/null; then
+            addgroup --quiet --system feedbackd
+        fi
+    ;;
+
+    abort-upgrade|abort-remove|abort-deconfigure)
+    ;;
+
+    *)
+        echo "postinst called with unknown argument \`$1'" >&2
+        exit 1
+    ;;
+esac
+
+# dh_installdeb will replace this with shell code automatically
+# generated by other debhelper scripts.
+
+#DEBHELPER#
+
+exit 0
+
diff --git a/debian/feedbackd.udev b/debian/feedbackd.udev
index b3faf73..93148d7 100644
--- a/debian/feedbackd.udev
+++ b/debian/feedbackd.udev
@@ -7,10 +7,10 @@ ACTION=="remove", GOTO="feedbackd_end"
 SUBSYSTEM=="input", KERNEL=="event*", ENV{ID_INPUT}=="1", ENV{ID_PATH}=="platform-vibrator", TAG+="uaccess", ENV{FEEDBACKD_TYPE}="vibra"
 
 # Front leds of the Librem5 (pre 5.9)
-SUBSYSTEM=="leds", DEVPATH=="*/phone:*:front", ENV{FEEDBACKD_TYPE}="led", RUN+="/usr/libexec/fbd-ledctrl -p %S%p -t pattern -G video"
+SUBSYSTEM=="leds", DEVPATH=="*/phone:*:front", ENV{FEEDBACKD_TYPE}="led", RUN+="/usr/libexec/fbd-ledctrl -p %S%p -t pattern -G feedbackd"
 # Front leds of the Librem5 (5.9 and later)
-SUBSYSTEM=="leds", DEVPATH=="*/*:status", ENV{FEEDBACKD_TYPE}="led", RUN+="/usr/libexec/fbd-ledctrl -p %S%p -t pattern -G video"
+SUBSYSTEM=="leds", DEVPATH=="*/*:status", ENV{FEEDBACKD_TYPE}="led", RUN+="/usr/libexec/fbd-ledctrl -p %S%p -t pattern -G feedbackd"
 # Front leds of the PinePhone
-SUBSYSTEM=="leds", DEVPATH=="*/*:indicator", ENV{FEEDBACKD_TYPE}="led", RUN+="/usr/libexec/fbd-ledctrl -p %S%p -t pattern -G video"
+SUBSYSTEM=="leds", DEVPATH=="*/*:indicator", ENV{FEEDBACKD_TYPE}="led", RUN+="/usr/libexec/fbd-ledctrl -p %S%p -t pattern -G feedbackd"
 
 LABEL="feedbackd_end"