From 551030b43601ee4ea59596c48442a2bd2ebb372c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Tue, 25 Feb 2020 18:55:24 +0100 Subject: [PATCH] rumble: Use a default pause Without that multiple counts sound odd so let's have good defaults. --- src/fbd-feedback-vibra-rumble.c | 5 +++-- src/fbd-feedback-vibra-rumble.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/fbd-feedback-vibra-rumble.c b/src/fbd-feedback-vibra-rumble.c index 4e62d09..16482d1 100644 --- a/src/fbd-feedback-vibra-rumble.c +++ b/src/fbd-feedback-vibra-rumble.c @@ -122,7 +122,7 @@ fbd_feedback_vibra_rumble_start_vibra (FbdFeedbackVibra *vibra) self->rumble = (duration / self->count) - self->pause; if (self->rumble <= 0) { self->rumble = FBD_FEEDBACK_VIBRA_DEFAULT_DURATION; - self->pause = 0; + self->pause = FBD_FEEDBACK_VIBRA_RUMBLE_DEFAULT_PAUSE; self->count = 1; } period = self->rumble + self->pause; @@ -162,7 +162,7 @@ fbd_feedback_vibra_rumble_class_init (FbdFeedbackVibraRumbleClass *klass) "pause", "Pause", "The pause in msecs between rumbles", - 0, G_MAXINT, 0, + 0, G_MAXINT, FBD_FEEDBACK_VIBRA_RUMBLE_DEFAULT_PAUSE, G_PARAM_CONSTRUCT_ONLY | G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS); g_object_class_install_properties (object_class, PROP_LAST_PROP, props); @@ -172,4 +172,5 @@ static void fbd_feedback_vibra_rumble_init (FbdFeedbackVibraRumble *self) { self->count = 1; + self->pause = FBD_FEEDBACK_VIBRA_RUMBLE_DEFAULT_PAUSE; } diff --git a/src/fbd-feedback-vibra-rumble.h b/src/fbd-feedback-vibra-rumble.h index 1a1cf1b..056c941 100644 --- a/src/fbd-feedback-vibra-rumble.h +++ b/src/fbd-feedback-vibra-rumble.h @@ -9,6 +9,8 @@ G_BEGIN_DECLS +#define FBD_FEEDBACK_VIBRA_RUMBLE_DEFAULT_PAUSE 100 + #define FBD_TYPE_FEEDBACK_VIBRA_RUMBLE (fbd_feedback_vibra_rumble_get_type()) G_DECLARE_FINAL_TYPE (FbdFeedbackVibraRumble, fbd_feedback_vibra_rumble, FBD,