SymbX/feedbackd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feedback-manager: Improve readability of add_event_feedbacks()

Browse Source 
Save one indent level and add the feedback at the very end. This
makes extending easier.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
This commit is contained in:
Guido Günther
2025-01-26 16:04:11 +01:00
parent 9bb2a528c6
commit 9fd06731ae
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/fbd-feedback-manager.c
+4 -4
View File
@@ -380,7 +380,9 @@ add_event_feedbacks (FbdFeedbackManager *self, FbdEvent *event, GSList *feedback
for (GSList *l = feedbacks; l; l = l->next) { for (GSList *l = feedbacks; l; l = l->next) {
FbdFeedbackBase *fb = FBD_FEEDBACK_BASE (l->data); FbdFeedbackBase *fb = FBD_FEEDBACK_BASE (l->data);
if (fbd_feedback_is_available (FBD_FEEDBACK_BASE (fb))) { if (!fbd_feedback_is_available (FBD_FEEDBACK_BASE (fb)))
continue;
/* Handle one haptic feedback at a time. In practice haptics can handle multiple /* Handle one haptic feedback at a time. In practice haptics can handle multiple
* patterns but none of the devices supports this atm */ * patterns but none of the devices supports this atm */
/* TODO: should respect priorities */ /* TODO: should respect priorities */
@@ -390,15 +392,13 @@ add_event_feedbacks (FbdFeedbackManager *self, FbdEvent *event, GSList *feedback
has_vibra = TRUE; has_vibra = TRUE;
} }
fbd_event_add_feedback (event, fb);
/* Events take priority over the haptic interface */ /* Events take priority over the haptic interface */
if (has_vibra) if (has_vibra)
fbd_haptic_manager_end_feedback (self->haptic_manager); fbd_haptic_manager_end_feedback (self->haptic_manager);
fbd_event_add_feedback (event, fb);
found_fb = TRUE; found_fb = TRUE;
} }
}
return found_fb; return found_fb;
} }