From d739a33a5fd5d484369180f8fbd62214712e0f44 Mon Sep 17 00:00:00 2001 From: Evangelos Ribeiro Tzaras Date: Fri, 4 Nov 2022 09:43:09 +0100 Subject: [PATCH] feedback-manager: Complete DBus call before emitting "feedback-ended" See previous commit adding the test (that now passes) for the reasoning. Fixes: #62 --- src/fbd-feedback-manager.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/fbd-feedback-manager.c b/src/fbd-feedback-manager.c index dbcf08d..9578bd8 100644 --- a/src/fbd-feedback-manager.c +++ b/src/fbd-feedback-manager.c @@ -384,6 +384,8 @@ fbd_feedback_manager_handle_trigger_feedback (LfbGdbusFeedback *object, found_fb = FALSE; } + lfb_gdbus_feedback_complete_trigger_feedback (object, invocation, event_id); + if (found_fb) { g_signal_connect_object (event, "feedbacks-ended", (GCallback) on_event_feedbacks_ended, @@ -397,7 +399,6 @@ fbd_feedback_manager_handle_trigger_feedback (LfbGdbusFeedback *object, FBD_EVENT_END_REASON_NOT_FOUND); } - lfb_gdbus_feedback_complete_trigger_feedback (object, invocation, event_id); return TRUE; }