log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers
This change has two benefits:
- The format string %m will now resolve to the specified error (or to
errno if the specified error is 0. This allows getting rid of a ton of
strerror() invocations, a function that is not thread-safe.
- The specified error can be passed to the journal in the ERRNO= field.
Now of course, we just need somebody to convert all cases of this:
log_error("Something happened: %s", strerror(-r));
into thus:
log_error_errno(-r, "Something happened: %m");
This commit is contained in:
@@ -44,7 +44,7 @@ static void systemd_kmod_log(
|
||||
|
||||
/* library logging is enabled at debug only */
|
||||
DISABLE_WARNING_FORMAT_NONLITERAL;
|
||||
log_metav(LOG_DEBUG, file, line, fn, format, args);
|
||||
log_metav(LOG_DEBUG, 0, file, line, fn, format, args);
|
||||
REENABLE_WARNING;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user