From 7eb234fe2b0ee139f5e5451babe1eecd100aa2ac Mon Sep 17 00:00:00 2001 From: Frantisek Sumsal Date: Thu, 4 Jan 2024 20:28:37 +0100 Subject: [PATCH 1/2] test: install correct kpartx udev rules on Ubuntu Follow-up for 519f0074cf. --- test/test-functions | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test-functions b/test/test-functions index 86a76a8d46..c543100654 100644 --- a/test/test-functions +++ b/test/test-functions @@ -1151,9 +1151,9 @@ install_multipath() { image_install kpartx /lib/udev/kpartx_id lsmod mpathpersist multipath multipathd partx image_install "${ROOTLIBDIR:?}"/system/multipathd.{service,socket} if get_bool "$LOOKS_LIKE_DEBIAN"; then - # Note: try both 60-kpartx.rules (as seen on Debian Sid with 0.9.4-7) and 90-kpartx.rules (as seen on + # Note: try both 60-kpartx.rules (as seen on Debian Sid with 0.9.4-7) and 95-kpartx.rules (as seen on # Ubuntu Jammy with 0.8.8-1ubuntu1.22.04.4) - inst_rules 56-dm-parts.rules 56-dm-mpath.rules 60-kpartx.rules 60-multipath.rules 68-del-part-nodes.rules 90-kpartx.rules + inst_rules 56-dm-parts.rules 56-dm-mpath.rules 60-kpartx.rules 60-multipath.rules 68-del-part-nodes.rules 95-kpartx.rules else inst_rules 11-dm-mpath.rules 11-dm-parts.rules 62-multipath.rules 66-kpartx.rules 68-del-part-nodes.rules fi From 91da9458f8e10cee6e3ea43a4592bbe07c08f1b1 Mon Sep 17 00:00:00 2001 From: Frantisek Sumsal Date: Thu, 4 Jan 2024 20:31:32 +0100 Subject: [PATCH 2/2] test: allow sanitized binaries to dump a core If a binary built with ASan crashes for a reason unrelated to ASan stuff, we're left with pretty much nothing, as there is neither an ASan trace nor a coredump. Let's make this slightly more debug-able by allowing such binaries to dump a core, but without the huge shadow map (we should be actually fine by just setting disable_coredump=0, since use_madv_dontdump defaults to true, but let's play it safe and not potentially dump a 16+ TB core file). --- test/test-functions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-functions b/test/test-functions index c543100654..016cf15682 100644 --- a/test/test-functions +++ b/test/test-functions @@ -995,7 +995,7 @@ create_asan_wrapper() { [[ -z "$ASAN_RT_PATH" ]] && dfatal "ASAN_RT_PATH is empty, but it shouldn't be" - default_asan_options="${ASAN_OPTIONS:-strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1}" + default_asan_options="${ASAN_OPTIONS:-strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1:disable_coredump=0:use_madv_dontdump=1}" default_ubsan_options="${UBSAN_OPTIONS:-print_stacktrace=1:print_summary=1:halt_on_error=1}" if [[ "$ASAN_COMPILER" == "clang" ]]; then