label: rework label_fix() implementations (#8583)
This reworks the SELinux and SMACK label fixing calls in a number of ways: 1. The two separate boolean arguments of these functions are converted into a flags type LabelFixFlags. 2. The operations are now implemented based on O_PATH. This should resolve TTOCTTOU races between determining the label for the file system object and applying it, as it it allows to pin the object while we are operating on it. 3. When changing a label fails we'll query the label previously set, and if matches what we want to set anyway we'll suppress the error. Also, all calls to label_fix() are now (void)ified, when we ignore the return values. Fixes: #8566
This commit is contained in:
committed by
Zbigniew Jędrzejewski-Szmek
parent
ffb3c2bd70
commit
08c849815c
+6
-1
@@ -23,7 +23,12 @@
|
||||
#include <stdbool.h>
|
||||
#include <sys/types.h>
|
||||
|
||||
int label_fix(const char *path, bool ignore_enoent, bool ignore_erofs);
|
||||
typedef enum LabelFixFlags {
|
||||
LABEL_IGNORE_ENOENT = 1U << 0,
|
||||
LABEL_IGNORE_EROFS = 1U << 1,
|
||||
} LabelFixFlags;
|
||||
|
||||
int label_fix(const char *path, LabelFixFlags flags);
|
||||
|
||||
int mkdir_label(const char *path, mode_t mode);
|
||||
int symlink_label(const char *old_path, const char *new_path);
|
||||
|
||||
Reference in New Issue
Block a user