treewide: auto-convert the simple cases to log_*_errno()

As a followup to 086891e5c1 "log: add an "error" parameter to all
low-level logging calls and intrdouce log_error_errno() as log calls
that take error numbers", use sed to convert the simple cases to use
the new macros:

find . -name '*.[ch]' | xargs sed -r -i -e \
's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/'

Multi-line log_*() invocations are not covered.
And we also should add log_unit_*_errno().
This commit is contained in:
Michal Schmidt
2014-11-28 12:04:41 +01:00
parent b4d23205f2
commit 0a1beeb642
173 changed files with 1001 additions and 1001 deletions
+3 -3
View File
@@ -823,7 +823,7 @@ static int setup_pam(
* If this fails, ignore the error - but expect sd-pam threads
* to fail to exit normally */
if (setresuid(uid, uid, uid) < 0)
log_error("Error: Failed to setresuid() in sd-pam: %s", strerror(-r));
log_error_errno(-r, "Error: Failed to setresuid() in sd-pam: %m");
/* Wait until our parent died. This will only work if
* the above setresuid() succeeds, otherwise the kernel
@@ -2819,7 +2819,7 @@ void exec_runtime_destroy(ExecRuntime *rt) {
r = asynchronous_job(remove_tmpdir_thread, rt->tmp_dir);
if (r < 0) {
log_warning("Failed to nuke %s: %s", rt->tmp_dir, strerror(-r));
log_warning_errno(-r, "Failed to nuke %s: %m", rt->tmp_dir);
free(rt->tmp_dir);
}
@@ -2831,7 +2831,7 @@ void exec_runtime_destroy(ExecRuntime *rt) {
r = asynchronous_job(remove_tmpdir_thread, rt->var_tmp_dir);
if (r < 0) {
log_warning("Failed to nuke %s: %s", rt->var_tmp_dir, strerror(-r));
log_warning_errno(-r, "Failed to nuke %s: %m", rt->var_tmp_dir);
free(rt->var_tmp_dir);
}