basic: make check-pointer-deref clean

Add the needed assert changes to make the code clean
for the new check-pointer-deref script.

Note that for `_cmp()` functions its a bit of a question
if we want `assert()` or `POINTER_MAY_BE_NULL()` here. The
former is more correct but it adds a (small) runtime hit. If
we use POINTER_MAY_BE_NULL() it is compiled out but strictly
speaking it is wrong (so at least we would need a comment).
This commit is contained in:
Michael Vogt
2026-03-31 18:30:40 +02:00
parent 1692d51eb2
commit 18e70eec2f
30 changed files with 146 additions and 3 deletions
+6
View File
@@ -11,6 +11,9 @@
#ifndef __GLIBC__
static bool safe_glob_verify(const char *p, const char *prefix) {
POINTER_MAY_BE_NULL(p);
POINTER_MAY_BE_NULL(prefix);
if (isempty(p))
return false; /* should not happen, but for safey. */
@@ -162,6 +165,9 @@ int glob_extend(char ***strv, const char *path, int flags) {
}
int glob_non_glob_prefix(const char *path, char **ret) {
assert(path);
assert(ret);
/* Return the path of the path that has no glob characters. */
size_t n = strcspn(path, GLOB_CHARS);