Bugprone argument comment - round 4 (#37380)
Follow up from https://github.com/systemd/systemd/pull/37356
This commit is contained in:
@@ -701,7 +701,7 @@ int cg_get_xattr_bool(const char *path, const char *name) {
|
||||
if (r < 0)
|
||||
return r;
|
||||
|
||||
return getxattr_at_bool(AT_FDCWD, fs, name, /* flags= */ 0);
|
||||
return getxattr_at_bool(AT_FDCWD, fs, name, /* at_flags= */ 0);
|
||||
}
|
||||
|
||||
int cg_remove_xattr(const char *path, const char *name) {
|
||||
@@ -2176,11 +2176,11 @@ int cg_is_delegated_fd(int fd) {
|
||||
|
||||
assert(fd >= 0);
|
||||
|
||||
r = getxattr_at_bool(fd, /* path= */ NULL, "trusted.delegate", /* flags= */ 0);
|
||||
r = getxattr_at_bool(fd, /* path= */ NULL, "trusted.delegate", /* at_flags= */ 0);
|
||||
if (!ERRNO_IS_NEG_XATTR_ABSENT(r))
|
||||
return r;
|
||||
|
||||
r = getxattr_at_bool(fd, /* path= */ NULL, "user.delegate", /* flags= */ 0);
|
||||
r = getxattr_at_bool(fd, /* path= */ NULL, "user.delegate", /* at_flags= */ 0);
|
||||
return ERRNO_IS_NEG_XATTR_ABSENT(r) ? false : r;
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -38,7 +38,7 @@ bool unsafe_transition(const struct stat *a, const struct stat *b);
|
||||
/* How many iterations to execute before returning -ELOOP */
|
||||
#define CHASE_MAX 32
|
||||
|
||||
int chase(const char *path_with_prefix, const char *root, ChaseFlags chase_flags, char **ret_path, int *ret_fd);
|
||||
int chase(const char *path_with_prefix, const char *root, ChaseFlags flags, char **ret_path, int *ret_fd);
|
||||
|
||||
int chaseat_prefix_root(const char *path, const char *root, char **ret);
|
||||
int chase_extract_filename(const char *path, const char *root, char **ret);
|
||||
|
||||
+1
-1
@@ -123,7 +123,7 @@ static int extension_release_strict_xattr_value(int extension_release_fd, const
|
||||
assert(filename);
|
||||
|
||||
/* No xattr or cannot parse it? Then skip this. */
|
||||
r = getxattr_at_bool(extension_release_fd, /* path= */ NULL, "user.extension-release.strict", /* flags= */ 0);
|
||||
r = getxattr_at_bool(extension_release_fd, /* path= */ NULL, "user.extension-release.strict", /* at_flags= */ 0);
|
||||
if (ERRNO_IS_NEG_XATTR_ABSENT(r))
|
||||
return log_debug_errno(r, "%s/%s does not have user.extension-release.strict xattr, ignoring.",
|
||||
extension_release_dir_path, filename);
|
||||
|
||||
@@ -1119,7 +1119,7 @@ int resolve_dev_console(char **ret) {
|
||||
* is a sign for container setups). */
|
||||
|
||||
_cleanup_free_ char *chased = NULL;
|
||||
r = chase("/dev/console", /* root= */ NULL, /* chase_flags= */ 0, &chased, /* ret_fd= */ NULL);
|
||||
r = chase("/dev/console", /* root= */ NULL, /* flags= */ 0, &chased, /* ret_fd= */ NULL);
|
||||
if (r < 0)
|
||||
return r;
|
||||
if (!path_equal(chased, "/dev/console")) {
|
||||
|
||||
@@ -143,7 +143,7 @@ int openpt_allocate(int flags, char **ret_peer);
|
||||
int openpt_allocate_in_namespace(const PidRef *pidref, int flags, char **ret_peer);
|
||||
|
||||
int vt_restore(int fd);
|
||||
int vt_release(int fd, bool restore_vt);
|
||||
int vt_release(int fd, bool restore);
|
||||
|
||||
void get_log_colors(int priority, const char **on, const char **off, const char **highlight);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user