Bugprone argument comment - round 4 (#37380)
Follow up from https://github.com/systemd/systemd/pull/37356
This commit is contained in:
@@ -34,7 +34,7 @@ typedef struct AskPasswordRequest {
|
||||
|
||||
int ask_password_tty(const AskPasswordRequest *req, AskPasswordFlags flags, char ***ret);
|
||||
int ask_password_plymouth(const AskPasswordRequest *req, AskPasswordFlags flags, char ***ret);
|
||||
int ask_password_agent(const AskPasswordRequest *req, AskPasswordFlags flag, char ***ret);
|
||||
int ask_password_auto(const AskPasswordRequest *req, AskPasswordFlags flag, char ***ret);
|
||||
int ask_password_agent(const AskPasswordRequest *req, AskPasswordFlags flags, char ***ret);
|
||||
int ask_password_auto(const AskPasswordRequest *req, AskPasswordFlags flags, char ***ret);
|
||||
|
||||
int acquire_user_ask_password_directory(char **ret);
|
||||
|
||||
@@ -1565,7 +1565,7 @@ int boot_config_load_auto(
|
||||
int boot_config_augment_from_loader(
|
||||
BootConfig *config,
|
||||
char **found_by_loader,
|
||||
bool only_auto) {
|
||||
bool auto_only) {
|
||||
|
||||
static const BootEntryAddons no_addons = (BootEntryAddons) {};
|
||||
static const char *const title_table[] = {
|
||||
@@ -1595,7 +1595,7 @@ int boot_config_augment_from_loader(
|
||||
continue;
|
||||
}
|
||||
|
||||
if (only_auto && !startswith(*i, "auto-"))
|
||||
if (auto_only && !startswith(*i, "auto-"))
|
||||
continue;
|
||||
|
||||
c = strdup(*i);
|
||||
|
||||
@@ -132,7 +132,7 @@ int boot_config_load_type1(
|
||||
int boot_config_finalize(BootConfig *config);
|
||||
int boot_config_load(BootConfig *config, const char *esp_path, const char *xbootldr_path);
|
||||
int boot_config_load_auto(BootConfig *config, const char *override_esp_path, const char *override_xbootldr_path);
|
||||
int boot_config_augment_from_loader(BootConfig *config, char **list, bool only_auto);
|
||||
int boot_config_augment_from_loader(BootConfig *config, char **list, bool auto_only);
|
||||
|
||||
int boot_config_select_special_entries(BootConfig *config, bool skip_efivars);
|
||||
|
||||
|
||||
@@ -1758,7 +1758,7 @@ static int pick_up_credential_one(
|
||||
AT_FDCWD, target_path,
|
||||
/* open_flags= */ 0,
|
||||
0644,
|
||||
/* flags= */ 0);
|
||||
/* copy_flags= */ 0);
|
||||
if (r < 0)
|
||||
return log_warning_errno(r, "Failed to copy credential %s → file %s: %m",
|
||||
credential_name, target_path);
|
||||
|
||||
@@ -669,7 +669,7 @@ static int compare_arch(Architecture a, Architecture b) {
|
||||
return 0;
|
||||
}
|
||||
|
||||
static bool image_filter_test(const ImageFilter *filter, PartitionDesignator d, const char *name) {
|
||||
static bool image_filter_test(const ImageFilter *filter, PartitionDesignator d, const char *label) {
|
||||
assert(d < _PARTITION_DESIGNATOR_MAX);
|
||||
|
||||
if (d < 0) /* For unspecified designators we have no filter expression */
|
||||
@@ -678,7 +678,7 @@ static bool image_filter_test(const ImageFilter *filter, PartitionDesignator d,
|
||||
if (!filter || !filter->pattern[d])
|
||||
return true;
|
||||
|
||||
return fnmatch(filter->pattern[d], strempty(name), FNM_NOESCAPE) == 0;
|
||||
return fnmatch(filter->pattern[d], strempty(label), FNM_NOESCAPE) == 0;
|
||||
}
|
||||
|
||||
static int dissect_image(
|
||||
|
||||
Reference in New Issue
Block a user