tree-wide: use -EBADF for fd initialization
-1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary.
This commit is contained in:
@@ -486,7 +486,7 @@ static int add_connection_socket(Context *context, int fd) {
|
||||
*c = (Connection) {
|
||||
.context = context,
|
||||
.server_fd = fd,
|
||||
.client_fd = -1,
|
||||
.client_fd = -EBADF,
|
||||
.server_to_client_buffer = {-1, -1},
|
||||
.client_to_server_buffer = {-1, -1},
|
||||
};
|
||||
@@ -504,7 +504,7 @@ static int add_connection_socket(Context *context, int fd) {
|
||||
static int accept_cb(sd_event_source *s, int fd, uint32_t revents, void *userdata) {
|
||||
_cleanup_free_ char *peer = NULL;
|
||||
Context *context = ASSERT_PTR(userdata);
|
||||
int nfd = -1, r;
|
||||
int nfd = -EBADF, r;
|
||||
|
||||
assert(s);
|
||||
assert(fd >= 0);
|
||||
|
||||
Reference in New Issue
Block a user