seccomp: also refuse sched_setattr() in RestrictRealtime=
RestrictRealtime= only filtered sched_setscheduler(). sched_setattr() can switch a task to SCHED_FIFO and SCHED_RR as well, and is the only way to get SCHED_DEADLINE, so a process that is otherwise allowed to use realtime scheduling (CAP_SYS_NICE, or a non-zero RLIMIT_RTPRIO) could bypass the restriction. The policy is passed in a struct sched_attr by pointer, which seccomp cannot inspect, so refuse the syscall altogether. This also affects non-realtime callers of sched_setattr() (nice, utilization clamps), which now get the same error as the refused policies. Document this in systemd.exec(5) and extend the test. CPUSchedulingPolicy= is applied through sched_setattr(), so a service manager running under RestrictRealtime=yes (e.g. in a container) could no longer start units with a non-realtime policy. Fall back to sched_setscheduler() on EPERM, which the filter still allows for these policies. This is not possible with CPUSchedulingResetOnFork=yes, as the filter refuses SCHED_RESET_ON_FORK too, so setting the policy still fails in that case. Signed-off-by: Ricardo Branco <rbranco@suse.de> (cherry picked from commit 590ff29a641a4ddb736ea59303af9721fc6c1400)
This commit is contained in:
committed by
Luca Boccassi
parent
5e4d9b64f5
commit
2d3dd0a4fc
@@ -5622,6 +5622,14 @@ int exec_invoke(
|
||||
};
|
||||
|
||||
r = RET_NERRNO(sched_setattr(/* pid= */ 0, &attr, /* flags= */ 0));
|
||||
if (r == -EPERM && !context->cpu_sched_reset_on_fork) {
|
||||
/* RestrictRealtime= refuses sched_setattr() altogether (possibly in an outer
|
||||
* manager), hence fall back to sched_setscheduler(), which it filters per policy.
|
||||
* We cannot do that with SCHED_RESET_ON_FORK, which the filter refuses too. */
|
||||
struct sched_param param = { .sched_priority = context->cpu_sched_priority };
|
||||
|
||||
r = RET_NERRNO(sched_setscheduler(/* pid= */ 0, context->cpu_sched_policy, ¶m));
|
||||
}
|
||||
if (r == -EINVAL && !sched_policy_supported(context->cpu_sched_policy)) {
|
||||
_cleanup_free_ char *s = NULL;
|
||||
(void) sched_policy_to_string_alloc(context->cpu_sched_policy, &s);
|
||||
|
||||
Reference in New Issue
Block a user