diff --git a/src/core/unit.c b/src/core/unit.c index 0d88f4f641..99e36fe455 100644 --- a/src/core/unit.c +++ b/src/core/unit.c @@ -3511,6 +3511,32 @@ int unit_load_related_unit(Unit *u, const char *type, Unit **_found) { return r; } +static int signal_name_owner_changed_install_handler(sd_bus_message *message, void *userdata, sd_bus_error *error) { + Unit *u = ASSERT_PTR(userdata); + const sd_bus_error *e; + int r; + + e = sd_bus_message_get_error(message); + if (!e) { + log_unit_trace(u, "Successfully installed NameOwnerChanged signal match."); + return 0; + } + + r = sd_bus_error_get_errno(e); + log_unit_error_errno(u, r, + "Unexpected error response on installing NameOwnerChanged signal match: %s", + bus_error_message(e, r)); + + /* If we failed to install NameOwnerChanged signal, also unref the bus slot of GetNameOwner(). */ + u->match_bus_slot = sd_bus_slot_unref(u->match_bus_slot); + u->get_name_owner_slot = sd_bus_slot_unref(u->get_name_owner_slot); + + if (UNIT_VTABLE(u)->bus_name_owner_change) + UNIT_VTABLE(u)->bus_name_owner_change(u, NULL); + + return 0; +} + static int signal_name_owner_changed(sd_bus_message *message, void *userdata, sd_bus_error *error) { const char *new_owner; Unit *u = ASSERT_PTR(userdata); @@ -3593,10 +3619,10 @@ int unit_install_bus_match(Unit *u, sd_bus *bus, const char *name) { r = bus_add_match_full( bus, &u->match_bus_slot, - true, + /* asynchronous = */ true, match, signal_name_owner_changed, - NULL, + signal_name_owner_changed_install_handler, u, timeout_usec); if (r < 0) @@ -3623,7 +3649,6 @@ int unit_install_bus_match(Unit *u, sd_bus *bus, const char *name) { get_name_owner_handler, u, timeout_usec); - if (r < 0) { u->match_bus_slot = sd_bus_slot_unref(u->match_bus_slot); return r; diff --git a/src/libsystemd/sd-bus/sd-bus.c b/src/libsystemd/sd-bus/sd-bus.c index 2683959db5..699761fc31 100644 --- a/src/libsystemd/sd-bus/sd-bus.c +++ b/src/libsystemd/sd-bus/sd-bus.c @@ -3616,7 +3616,6 @@ int bus_add_match_full( add_match_callback, s, timeout_usec); - if (r < 0) return r;