From 8ecd67e18e0890abf3fff33fa427082691fa43a4 Mon Sep 17 00:00:00 2001
From: Luca Boccassi <bluca@debian.org>
Date: Sun, 16 Jul 2023 00:39:13 +0100
Subject: [PATCH 1/3] efi: add assert to silence coverity

CID#1502668
---
 src/boot/efi/efi-string.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/boot/efi/efi-string.c b/src/boot/efi/efi-string.c
index 4400591255..ffe8552453 100644
--- a/src/boot/efi/efi-string.c
+++ b/src/boot/efi/efi-string.c
@@ -544,9 +544,11 @@ static bool push_str(FormatContext *ctx, SpecifierContext *sp) {
         if (sp->wstr && sizeof(wchar_t) == sizeof(char16_t)) {
                 memcpy(ctx->buf + ctx->n, sp->wstr, sp->len * sizeof(*sp->wstr));
                 ctx->n += sp->len;
-        } else
+        } else {
+                assert(sp->str || sp->wstr);
                 for (size_t i = 0; i < sp->len; i++)
                         ctx->buf[ctx->n++] = sp->str ? sp->str[i] : sp->wstr[i];
+        }
 
         if (sp->align_left)
                 push_padding(ctx, ' ', sp->padded_len);

From 5f03212abb1c189259ec89faa3b5c9be66bb6d1c Mon Sep 17 00:00:00 2001
From: Luca Boccassi <bluca@debian.org>
Date: Sun, 16 Jul 2023 00:44:46 +0100
Subject: [PATCH 2/3] glob-util: add assert to silence coverity

CID#1491968
---
 src/basic/glob-util.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/basic/glob-util.c b/src/basic/glob-util.c
index fd60a6eda2..802ca8c655 100644
--- a/src/basic/glob-util.c
+++ b/src/basic/glob-util.c
@@ -63,6 +63,8 @@ int glob_first(const char *path, char **ret_first) {
                 return k;
 
         if (ret_first) {
+                assert(g.gl_pathv && g.gl_pathv[0]);
+
                 char *first = strdup(g.gl_pathv[0]);
                 if (!first)
                         return log_oom_debug();

From d80cc39558ec7e596d594d1aadc4df81262611f8 Mon Sep 17 00:00:00 2001
From: Luca Boccassi <bluca@debian.org>
Date: Sun, 16 Jul 2023 01:10:47 +0100
Subject: [PATCH 3/3] bus: add some minimal bounds check on signatures

CID#1491292
CID#1491291
CID#1491290
CID#1491289
CID#1491284
CID#1491281
CID#1491280
CID#1491278
---
 src/busctl/busctl.c                 | 5 ++++-
 src/libsystemd/sd-bus/bus-message.c | 6 ++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/busctl/busctl.c b/src/busctl/busctl.c
index 72eed36335..c1a0479015 100644
--- a/src/busctl/busctl.c
+++ b/src/busctl/busctl.c
@@ -1627,8 +1627,11 @@ static int message_append_cmdline(sd_bus_message *m, const char *signature, char
                         p--;
 
                         r = signature_element_length(signature, &k);
-                        if (r < 0)
+                        if (r < 0 || k < 2) {
+                                if (r >= 0 && k < 2)
+                                        r = -ERANGE;
                                 return log_error_errno(r, "Invalid struct/dict entry signature: %m");
+                        }
 
                         {
                                 char s[k-1];
diff --git a/src/libsystemd/sd-bus/bus-message.c b/src/libsystemd/sd-bus/bus-message.c
index 3cf1419a14..f1cf6a8cc4 100644
--- a/src/libsystemd/sd-bus/bus-message.c
+++ b/src/libsystemd/sd-bus/bus-message.c
@@ -2027,6 +2027,8 @@ _public_ int sd_bus_message_appendv(
                         r = signature_element_length(t, &k);
                         if (r < 0)
                                 return r;
+                        if (k < 2)
+                                return -ERANGE;
 
                         {
                                 char s[k - 1];
@@ -3470,6 +3472,8 @@ _public_ int sd_bus_message_readv(
                         r = signature_element_length(t, &k);
                         if (r < 0)
                                 return r;
+                        if (k < 2)
+                                return -ERANGE;
 
                         {
                                 char s[k - 1];
@@ -3650,6 +3654,8 @@ _public_ int sd_bus_message_skip(sd_bus_message *m, const char *types) {
                 r = signature_element_length(types, &k);
                 if (r < 0)
                         return r;
+                if (k < 2)
+                        return -ERANGE;
 
                 {
                         char s[k-1];