From 4eaf0d9401ab26609b737fe25aa19dcc1e1aa314 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Thu, 9 Jan 2020 14:55:15 +0100 Subject: [PATCH] mount-util: don't mask away MS_RDONLY twice We have the flags mask for that, and if callers really wanted us to mask this away, then they should pass the correct mask. --- src/shared/mount-util.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/shared/mount-util.c b/src/shared/mount-util.c index cf500a126b..935691ce77 100644 --- a/src/shared/mount-util.c +++ b/src/shared/mount-util.c @@ -237,7 +237,6 @@ int bind_remount_recursive_with_mountinfo( orig_flags = 0; (void) get_mount_flags(simplified, &orig_flags, table); - orig_flags &= ~MS_RDONLY; if (mount(NULL, simplified, NULL, (orig_flags & ~flags_mask)|MS_BIND|MS_REMOUNT|new_flags, NULL) < 0) return -errno; @@ -279,7 +278,6 @@ int bind_remount_recursive_with_mountinfo( /* Try to reuse the original flag set */ orig_flags = 0; (void) get_mount_flags(x, &orig_flags, table); - orig_flags &= ~MS_RDONLY; if (mount(NULL, x, NULL, (orig_flags & ~flags_mask)|MS_BIND|MS_REMOUNT|new_flags, NULL) < 0) return -errno;