From 4f18ff2e29b8054f30b084abcabf5f689f4b340b Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Wed, 25 Jun 2025 04:51:20 +0900 Subject: [PATCH] tree-wide: include unistd.h where necessary We use symbols provided by unistd.h without including it. E.g. open(), close(), read(), write(), access(), symlink(), unlink(), rmdir(), fsync(), syncfs(), lseek(), ftruncate(), fchown(), dup2(), pipe2(), getuid(), getgid(), gettid(), getppid(), pipe2(), execv(), _exit(), environ, STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO, F_OK, and their friends and variants, so on. Currently, unistd.h is indirectly included mainly in the following two paths: - through missing_syscall.h, which is planned to covert to .c file. - through signal.h -> bits/sigstksz.h, which is new since glibc-2.34. Note, signal.h is included by sd-eevent.h. So, many source files indirectly include unistd.h if newer glibc is used. Currently, our baseline on glibc is 2.31. We need to support glibc older than 2.34, but unfortunately, we do not have any CI environments with such old glibc. CIFuzz uses glibc-2.31, but it builds only fuzzers, and many files are even not compiled. --- src/analyze/analyze-condition.c | 1 + src/analyze/analyze-verify-util.c | 1 + src/basic/hashmap.c | 1 + src/basic/lock-util.c | 1 + src/basic/namespace-util.c | 1 + src/basic/pidref.c | 2 ++ src/basic/random-util.c | 1 + src/basic/signal-util.c | 1 + src/core/cgroup.c | 1 + src/core/crash-handler.c | 1 + src/core/dbus-execute.c | 1 + src/core/dbus-unit.c | 2 ++ src/core/dynamic-user.c | 1 + src/core/emergency-action.c | 1 + src/core/exec-credential.c | 1 + src/core/exec-invoke.c | 1 + src/core/execute-serialize.c | 2 ++ src/core/import-creds.c | 1 + src/core/load-fragment.c | 1 + src/core/selinux-access.c | 1 + src/home/homectl.c | 1 + src/home/homed-home.c | 1 + src/home/homed-manager-bus.c | 1 + src/home/homed-manager.c | 1 + src/home/homework-cifs.c | 1 + src/home/homework-fscrypt.c | 1 + src/home/homework-luks.c | 1 + src/home/homework.c | 1 + src/import/import-fs.c | 1 + src/import/import.c | 1 + src/import/importctl.c | 1 + src/import/importd.c | 1 + src/journal-remote/fuzz-journal-remote.c | 1 + src/journal/fuzz-journald-native-fd.c | 2 ++ src/journal/journald-context.c | 1 + src/journal/journald-manager.c | 1 + src/libsystemd-network/sd-dhcp-server-lease.c | 1 + src/libsystemd/sd-bus/test-bus-watch-bind.c | 1 + src/libsystemd/sd-event/sd-event.c | 1 + src/libudev/libudev-device.c | 2 ++ src/login/logind-brightness.c | 2 ++ src/machine/image-dbus.c | 2 ++ src/machine/image-varlink.c | 2 ++ src/machine/image.c | 2 ++ src/machine/machined-core.c | 3 +++ src/mountfsd/mountfsd-manager.c | 1 + src/mountfsd/mountwork.c | 1 + src/network/networkd.c | 1 + src/nspawn/nspawn-mount.c | 1 + src/nspawn/nspawn-network.c | 1 + src/nsresourced/nsresourced-manager.c | 1 + src/nsresourced/nsresourcework.c | 1 + src/nsresourced/test-userns-restrict.c | 1 + src/portable/portable.c | 1 + src/repart/repart.c | 1 + src/run/run.c | 1 + src/shared/bus-polkit.c | 2 ++ src/shared/dissect-image.c | 1 + src/shared/edit-util.c | 1 + src/shared/journal-util.c | 2 ++ src/shared/portable-util.c | 2 ++ src/shared/serialize.c | 1 + src/shared/tests.c | 1 + src/sulogin-shell/sulogin-shell.c | 2 ++ src/systemctl/systemctl-sysv-compat.c | 1 + src/sysupdate/sysupdate-transfer.c | 1 + src/sysupdate/sysupdated.c | 1 + src/test/test-cgroup-util.c | 2 ++ src/test/test-conf-files.c | 1 + src/test/test-conf-parser.c | 2 ++ src/test/test-dirent-util.c | 1 + src/test/test-env-util.c | 2 ++ src/test/test-execute.c | 1 + src/test/test-hashmap-plain.c | 2 ++ src/test/test-json.c | 1 + src/test/test-loop-block.c | 1 + src/test/test-macro.c | 1 + src/test/test-memfd-util.c | 2 ++ src/test/test-mount-util.c | 1 + src/test/test-namespace.c | 1 + src/test/test-os-util.c | 1 + src/test/test-path.c | 1 + src/test/test-proc-cmdline.c | 1 + src/test/test-psi-util.c | 2 ++ src/test/test-rlimit-util.c | 1 + src/test/test-set.c | 2 ++ src/test/test-string-util.c | 2 ++ src/test/test-tmpfile-util.c | 1 + src/test/test-uid-range.c | 2 ++ src/test/test-unit-file.c | 2 ++ src/test/test-unit-name.c | 1 + src/test/test-user-util.c | 2 ++ src/test/test-varlink.c | 1 + src/test/test-vpick.c | 2 ++ src/test/test-watch-pid.c | 2 ++ src/timesync/timesyncd-manager.c | 1 + src/timesync/timesyncd.c | 1 + src/udev/udev-manager.c | 1 + src/udev/udev-spawn.c | 2 ++ src/udev/udev-watch.c | 1 + src/userdb/userdbd-manager.c | 1 + src/varlinkctl/varlinkctl.c | 1 + src/volatile-root/volatile-root.c | 1 + 103 files changed, 132 insertions(+) diff --git a/src/analyze/analyze-condition.c b/src/analyze/analyze-condition.c index a0330a6109..637a34e389 100644 --- a/src/analyze/analyze-condition.c +++ b/src/analyze/analyze-condition.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "analyze.h" #include "analyze-condition.h" diff --git a/src/analyze/analyze-verify-util.c b/src/analyze/analyze-verify-util.c index 6c668222bd..40952531d7 100644 --- a/src/analyze/analyze-verify-util.c +++ b/src/analyze/analyze-verify-util.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-bus.h" diff --git a/src/basic/hashmap.c b/src/basic/hashmap.c index bd6bdc359b..6d4c57e81b 100644 --- a/src/basic/hashmap.c +++ b/src/basic/hashmap.c @@ -2,6 +2,7 @@ #include #include +#include #if HAVE_VALGRIND_VALGRIND_H # include #endif diff --git a/src/basic/lock-util.c b/src/basic/lock-util.c index 5921cc8f93..83ada416fd 100644 --- a/src/basic/lock-util.c +++ b/src/basic/lock-util.c @@ -6,6 +6,7 @@ #include #include #include +#include #include "alloc-util.h" #include "errno-util.h" diff --git a/src/basic/namespace-util.c b/src/basic/namespace-util.c index f7d81cdc7d..bed67619e2 100644 --- a/src/basic/namespace-util.c +++ b/src/basic/namespace-util.c @@ -3,6 +3,7 @@ #include #include #include +#include #include "errno-util.h" #include "fd-util.h" diff --git a/src/basic/pidref.c b/src/basic/pidref.c index eeccc537c9..3aee706a9c 100644 --- a/src/basic/pidref.c +++ b/src/basic/pidref.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "alloc-util.h" #include "errno-util.h" #include "fd-util.h" diff --git a/src/basic/random-util.c b/src/basic/random-util.c index 486a523bc5..1726873237 100644 --- a/src/basic/random-util.c +++ b/src/basic/random-util.c @@ -7,6 +7,7 @@ #include #include #include +#include #include "alloc-util.h" #include "fd-util.h" diff --git a/src/basic/signal-util.c b/src/basic/signal-util.c index 4080d96792..5a14046f01 100644 --- a/src/basic/signal-util.c +++ b/src/basic/signal-util.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "errno-util.h" #include "missing_syscall.h" diff --git a/src/core/cgroup.c b/src/core/cgroup.c index 7822360009..ae322eead0 100644 --- a/src/core/cgroup.c +++ b/src/core/cgroup.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-bus.h" #include "sd-messages.h" diff --git a/src/core/crash-handler.c b/src/core/crash-handler.c index b2b09d493a..124d4b886b 100644 --- a/src/core/crash-handler.c +++ b/src/core/crash-handler.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-messages.h" diff --git a/src/core/dbus-execute.c b/src/core/dbus-execute.c index 8ad3ebc5fa..3719984caf 100644 --- a/src/core/dbus-execute.c +++ b/src/core/dbus-execute.c @@ -2,6 +2,7 @@ #include #include +#include #include "af-list.h" #include "alloc-util.h" diff --git a/src/core/dbus-unit.c b/src/core/dbus-unit.c index e26a04299d..dc5fbfbf2a 100644 --- a/src/core/dbus-unit.c +++ b/src/core/dbus-unit.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "sd-bus.h" #include "alloc-util.h" diff --git a/src/core/dynamic-user.c b/src/core/dynamic-user.c index e69f6557a5..6d17c9a129 100644 --- a/src/core/dynamic-user.c +++ b/src/core/dynamic-user.c @@ -3,6 +3,7 @@ #include #include #include +#include #include "clean-ipc.h" #include "dynamic-user.h" diff --git a/src/core/emergency-action.c b/src/core/emergency-action.c index cb460d0f03..989bb1753e 100644 --- a/src/core/emergency-action.c +++ b/src/core/emergency-action.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "ansi-color.h" #include "emergency-action.h" diff --git a/src/core/exec-credential.c b/src/core/exec-credential.c index 06a2794c82..8f91d7c0ce 100644 --- a/src/core/exec-credential.c +++ b/src/core/exec-credential.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "acl-util.h" #include "cgroup.h" diff --git a/src/core/exec-invoke.c b/src/core/exec-invoke.c index 46f8ea36c9..ec6729ae37 100644 --- a/src/core/exec-invoke.c +++ b/src/core/exec-invoke.c @@ -10,6 +10,7 @@ #include #include #include +#include #if HAVE_PAM #include diff --git a/src/core/execute-serialize.c b/src/core/execute-serialize.c index 3f7453c5f8..8fc3890214 100644 --- a/src/core/execute-serialize.c +++ b/src/core/execute-serialize.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "af-list.h" #include "capability-util.h" #include "cgroup.h" diff --git a/src/core/import-creds.c b/src/core/import-creds.c index 9a54196300..dc37c0d573 100644 --- a/src/core/import-creds.c +++ b/src/core/import-creds.c @@ -2,6 +2,7 @@ #include #include +#include #include "confidential-virt.h" #include "copy.h" diff --git a/src/core/load-fragment.c b/src/core/load-fragment.c index 28bd91fa1f..bed01029dc 100644 --- a/src/core/load-fragment.c +++ b/src/core/load-fragment.c @@ -5,6 +5,7 @@ #include #include +#include #include "sd-bus.h" #include "sd-messages.h" diff --git a/src/core/selinux-access.c b/src/core/selinux-access.c index 9798569cf0..d56f9456f6 100644 --- a/src/core/selinux-access.c +++ b/src/core/selinux-access.c @@ -6,6 +6,7 @@ #include #include +#include #include "sd-bus.h" diff --git a/src/home/homectl.c b/src/home/homectl.c index b134adcfd4..f27c7f7875 100644 --- a/src/home/homectl.c +++ b/src/home/homectl.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-bus.h" diff --git a/src/home/homed-home.c b/src/home/homed-home.c index 4b5aed46bf..90e3944f6b 100644 --- a/src/home/homed-home.c +++ b/src/home/homed-home.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-bus.h" diff --git a/src/home/homed-manager-bus.c b/src/home/homed-manager-bus.c index 64acbf07d0..9ffa758ee5 100644 --- a/src/home/homed-manager-bus.c +++ b/src/home/homed-manager-bus.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-bus.h" #include "sd-event.h" diff --git a/src/home/homed-manager.c b/src/home/homed-manager.c index 072cb12360..2175ca7f3c 100644 --- a/src/home/homed-manager.c +++ b/src/home/homed-manager.c @@ -9,6 +9,7 @@ #include #include #include +#include #include "sd-bus.h" #include "sd-event.h" diff --git a/src/home/homework-cifs.c b/src/home/homework-cifs.c index d04f65a3f8..1a2195371a 100644 --- a/src/home/homework-cifs.c +++ b/src/home/homework-cifs.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "alloc-util.h" #include "env-util.h" diff --git a/src/home/homework-fscrypt.c b/src/home/homework-fscrypt.c index 9debaf943a..8a3bb27655 100644 --- a/src/home/homework-fscrypt.c +++ b/src/home/homework-fscrypt.c @@ -7,6 +7,7 @@ #include #include #include +#include #include "alloc-util.h" #include "errno-util.h" diff --git a/src/home/homework-luks.c b/src/home/homework-luks.c index 01ac02b40a..326f941312 100644 --- a/src/home/homework-luks.c +++ b/src/home/homework-luks.c @@ -5,6 +5,7 @@ #include #include #include +#include #if HAVE_VALGRIND_MEMCHECK_H #include #endif diff --git a/src/home/homework.c b/src/home/homework.c index 689267d819..57a7b77344 100644 --- a/src/home/homework.c +++ b/src/home/homework.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-daemon.h" diff --git a/src/import/import-fs.c b/src/import/import-fs.c index a60849fe10..22fddaa58b 100644 --- a/src/import/import-fs.c +++ b/src/import/import-fs.c @@ -2,6 +2,7 @@ #include #include +#include #include "alloc-util.h" #include "ansi-color.h" diff --git a/src/import/import.c b/src/import/import.c index 72757d2ec7..9b458dff9f 100644 --- a/src/import/import.c +++ b/src/import/import.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-event.h" diff --git a/src/import/importctl.c b/src/import/importctl.c index 5fd8af72ef..ecabf61e9e 100644 --- a/src/import/importctl.c +++ b/src/import/importctl.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-bus.h" #include "sd-event.h" diff --git a/src/import/importd.c b/src/import/importd.c index 95c3e2b433..5289707ec8 100644 --- a/src/import/importd.c +++ b/src/import/importd.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-bus.h" #include "sd-daemon.h" diff --git a/src/journal-remote/fuzz-journal-remote.c b/src/journal-remote/fuzz-journal-remote.c index e8d98b29eb..9119142e82 100644 --- a/src/journal-remote/fuzz-journal-remote.c +++ b/src/journal-remote/fuzz-journal-remote.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-journal.h" diff --git a/src/journal/fuzz-journald-native-fd.c b/src/journal/fuzz-journald-native-fd.c index 0b8a4a2334..ea07c5a354 100644 --- a/src/journal/fuzz-journald-native-fd.c +++ b/src/journal/fuzz-journald-native-fd.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "fd-util.h" #include "fuzz.h" #include "fuzz-journald.h" diff --git a/src/journal/journald-context.c b/src/journal/journald-context.c index 258bccf6bd..a6b34f14e4 100644 --- a/src/journal/journald-context.c +++ b/src/journal/journald-context.c @@ -5,6 +5,7 @@ #endif #include +#include #include "alloc-util.h" #include "audit-util.h" diff --git a/src/journal/journald-manager.c b/src/journal/journald-manager.c index 3443e6a965..6aa732e0ee 100644 --- a/src/journal/journald-manager.c +++ b/src/journal/journald-manager.c @@ -6,6 +6,7 @@ #include #include #include +#include #include "sd-daemon.h" #include "sd-journal.h" diff --git a/src/libsystemd-network/sd-dhcp-server-lease.c b/src/libsystemd-network/sd-dhcp-server-lease.c index 35a1e7bb18..1daafde716 100644 --- a/src/libsystemd-network/sd-dhcp-server-lease.c +++ b/src/libsystemd-network/sd-dhcp-server-lease.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-event.h" diff --git a/src/libsystemd/sd-bus/test-bus-watch-bind.c b/src/libsystemd/sd-bus/test-bus-watch-bind.c index ff4a2b1fce..158def7f75 100644 --- a/src/libsystemd/sd-bus/test-bus-watch-bind.c +++ b/src/libsystemd/sd-bus/test-bus-watch-bind.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-bus.h" #include "sd-event.h" diff --git a/src/libsystemd/sd-event/sd-event.c b/src/libsystemd/sd-event/sd-event.c index 9f72a1bfa6..3345a6a80a 100644 --- a/src/libsystemd/sd-event/sd-event.c +++ b/src/libsystemd/sd-event/sd-event.c @@ -5,6 +5,7 @@ #include #include #include +#include #include "sd-daemon.h" #include "sd-event.h" diff --git a/src/libudev/libudev-device.c b/src/libudev/libudev-device.c index d7ccadae66..22ff6075e8 100644 --- a/src/libudev/libudev-device.c +++ b/src/libudev/libudev-device.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "libudev.h" #include "sd-device.h" diff --git a/src/login/logind-brightness.c b/src/login/logind-brightness.c index da6f424a14..47f6e2d18f 100644 --- a/src/login/logind-brightness.c +++ b/src/login/logind-brightness.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "sd-bus.h" #include "sd-device.h" #include "sd-event.h" diff --git a/src/machine/image-dbus.c b/src/machine/image-dbus.c index 4ae3655840..8bc6565079 100644 --- a/src/machine/image-dbus.c +++ b/src/machine/image-dbus.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "sd-bus.h" #include "alloc-util.h" diff --git a/src/machine/image-varlink.c b/src/machine/image-varlink.c index 82ea7122e3..42f53049b7 100644 --- a/src/machine/image-varlink.c +++ b/src/machine/image-varlink.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "sd-json.h" #include "sd-varlink.h" diff --git a/src/machine/image.c b/src/machine/image.c index 89e1c68e25..9b080e3dc0 100644 --- a/src/machine/image.c +++ b/src/machine/image.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "sd-bus.h" #include "discover-image.h" diff --git a/src/machine/machined-core.c b/src/machine/machined-core.c index b87974a5dc..93f1cc5ee8 100644 --- a/src/machine/machined-core.c +++ b/src/machine/machined-core.c @@ -1,6 +1,9 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "sd-event.h" + #include "cgroup-util.h" #include "copy.h" #include "discover-image.h" diff --git a/src/mountfsd/mountfsd-manager.c b/src/mountfsd/mountfsd-manager.c index 6fb49c70a1..0fe69b7833 100644 --- a/src/mountfsd/mountfsd-manager.c +++ b/src/mountfsd/mountfsd-manager.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-daemon.h" diff --git a/src/mountfsd/mountwork.c b/src/mountfsd/mountwork.c index 0efdcf57c5..21837b96ff 100644 --- a/src/mountfsd/mountwork.c +++ b/src/mountfsd/mountwork.c @@ -4,6 +4,7 @@ #include #include #include +#include #include "sd-daemon.h" #include "sd-event.h" diff --git a/src/network/networkd.c b/src/network/networkd.c index 29ee7c52b3..2ce32fe4f3 100644 --- a/src/network/networkd.c +++ b/src/network/networkd.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-event.h" diff --git a/src/nspawn/nspawn-mount.c b/src/nspawn/nspawn-mount.c index 96647b5ae4..d4ac649c9f 100644 --- a/src/nspawn/nspawn-mount.c +++ b/src/nspawn/nspawn-mount.c @@ -2,6 +2,7 @@ #include #include +#include #include "alloc-util.h" #include "chase.h" diff --git a/src/nspawn/nspawn-network.c b/src/nspawn/nspawn-network.c index e828d0f141..4282bae233 100644 --- a/src/nspawn/nspawn-network.c +++ b/src/nspawn/nspawn-network.c @@ -6,6 +6,7 @@ #include #include #include +#include #include "sd-device.h" #include "sd-id128.h" diff --git a/src/nsresourced/nsresourced-manager.c b/src/nsresourced/nsresourced-manager.c index 6f59b9e5f7..a3a8e0b544 100644 --- a/src/nsresourced/nsresourced-manager.c +++ b/src/nsresourced/nsresourced-manager.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-daemon.h" diff --git a/src/nsresourced/nsresourcework.c b/src/nsresourced/nsresourcework.c index 11cce5b1fb..3ec575ac48 100644 --- a/src/nsresourced/nsresourcework.c +++ b/src/nsresourced/nsresourcework.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include "sd-daemon.h" diff --git a/src/nsresourced/test-userns-restrict.c b/src/nsresourced/test-userns-restrict.c index 61d4cd64bc..e4741784f2 100644 --- a/src/nsresourced/test-userns-restrict.c +++ b/src/nsresourced/test-userns-restrict.c @@ -3,6 +3,7 @@ #include #include #include +#include #include "errno-util.h" #include "fd-util.h" diff --git a/src/portable/portable.c b/src/portable/portable.c index 1e19096174..a2da4d2ab3 100644 --- a/src/portable/portable.c +++ b/src/portable/portable.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-bus.h" #include "sd-messages.h" diff --git a/src/repart/repart.c b/src/repart/repart.c index 2a9e90314f..76253c4a38 100644 --- a/src/repart/repart.c +++ b/src/repart/repart.c @@ -5,6 +5,7 @@ #include #include #include +#include #include "sd-id128.h" #include "sd-json.h" diff --git a/src/run/run.c b/src/run/run.c index 60ee96abb0..484a7d3a6f 100644 --- a/src/run/run.c +++ b/src/run/run.c @@ -5,6 +5,7 @@ #include #include #include +#include #include "sd-bus.h" #include "sd-daemon.h" diff --git a/src/shared/bus-polkit.c b/src/shared/bus-polkit.c index 176b2899db..5624e022a1 100644 --- a/src/shared/bus-polkit.c +++ b/src/shared/bus-polkit.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "sd-bus.h" #include "sd-event.h" diff --git a/src/shared/dissect-image.c b/src/shared/dissect-image.c index 20afa421d1..72165910f1 100644 --- a/src/shared/dissect-image.c +++ b/src/shared/dissect-image.c @@ -4,6 +4,7 @@ #include #include #include +#include #if HAVE_OPENSSL #include diff --git a/src/shared/edit-util.c b/src/shared/edit-util.c index c352994e4e..2887e7fa29 100644 --- a/src/shared/edit-util.c +++ b/src/shared/edit-util.c @@ -3,6 +3,7 @@ #include #include #include +#include #include "alloc-util.h" #include "copy.h" diff --git a/src/shared/journal-util.c b/src/shared/journal-util.c index e30bd522bb..8df4249220 100644 --- a/src/shared/journal-util.c +++ b/src/shared/journal-util.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "sd-bus.h" #include "sd-journal.h" diff --git a/src/shared/portable-util.c b/src/shared/portable-util.c index 8ec6e8880b..d474db2495 100644 --- a/src/shared/portable-util.c +++ b/src/shared/portable-util.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "alloc-util.h" #include "fs-util.h" #include "nulstr-util.h" diff --git a/src/shared/serialize.c b/src/shared/serialize.c index 4d0be059bd..a0b41b281e 100644 --- a/src/shared/serialize.c +++ b/src/shared/serialize.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-id128.h" diff --git a/src/shared/tests.c b/src/shared/tests.c index 5820c0d13f..35949ee448 100644 --- a/src/shared/tests.c +++ b/src/shared/tests.c @@ -5,6 +5,7 @@ #include #include #include +#include #include "sd-bus.h" #include "sd-daemon.h" diff --git a/src/sulogin-shell/sulogin-shell.c b/src/sulogin-shell/sulogin-shell.c index d074f6b543..2e9380d8fe 100644 --- a/src/sulogin-shell/sulogin-shell.c +++ b/src/sulogin-shell/sulogin-shell.c @@ -3,6 +3,8 @@ Copyright © 2017 Felipe Sateler ***/ +#include + #include "sd-bus.h" #include "alloc-util.h" diff --git a/src/systemctl/systemctl-sysv-compat.c b/src/systemctl/systemctl-sysv-compat.c index 60e62d82d7..915e2f8930 100644 --- a/src/systemctl/systemctl-sysv-compat.c +++ b/src/systemctl/systemctl-sysv-compat.c @@ -2,6 +2,7 @@ #include #include +#include #include "env-util.h" #include "fd-util.h" diff --git a/src/sysupdate/sysupdate-transfer.c b/src/sysupdate/sysupdate-transfer.c index 104da0a68d..d3e71bb21e 100644 --- a/src/sysupdate/sysupdate-transfer.c +++ b/src/sysupdate/sysupdate-transfer.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-id128.h" diff --git a/src/sysupdate/sysupdated.c b/src/sysupdate/sysupdated.c index 1bee4dd7bc..a46e4fdafc 100644 --- a/src/sysupdate/sysupdated.c +++ b/src/sysupdate/sysupdated.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-bus.h" #include "sd-json.h" diff --git a/src/test/test-cgroup-util.c b/src/test/test-cgroup-util.c index 4e7d52f5bc..0512532d0b 100644 --- a/src/test/test-cgroup-util.c +++ b/src/test/test-cgroup-util.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "alloc-util.h" #include "cgroup-util.h" #include "errno-util.h" diff --git a/src/test/test-conf-files.c b/src/test/test-conf-files.c index ec60e24cff..1680c68368 100644 --- a/src/test/test-conf-files.c +++ b/src/test/test-conf-files.c @@ -4,6 +4,7 @@ ***/ #include +#include #include "alloc-util.h" #include "conf-files.h" diff --git a/src/test/test-conf-parser.c b/src/test/test-conf-parser.c index 86b3a565ad..77e321d94c 100644 --- a/src/test/test-conf-parser.c +++ b/src/test/test-conf-parser.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "conf-parser.h" #include "fd-util.h" #include "fileio.h" diff --git a/src/test/test-dirent-util.c b/src/test/test-dirent-util.c index b5a903fa11..9b84ddaaee 100644 --- a/src/test/test-dirent-util.c +++ b/src/test/test-dirent-util.c @@ -4,6 +4,7 @@ #include #include #include +#include #include "dirent-util.h" #include "fs-util.h" diff --git a/src/test/test-env-util.c b/src/test/test-env-util.c index aa733704bc..d45f210689 100644 --- a/src/test/test-env-util.c +++ b/src/test/test-env-util.c @@ -1,6 +1,8 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include + #include "env-util.h" #include "parse-util.h" #include "process-util.h" diff --git a/src/test/test-execute.c b/src/test/test-execute.c index 335eb0d04c..621bbd4990 100644 --- a/src/test/test-execute.c +++ b/src/test/test-execute.c @@ -6,6 +6,7 @@ #include #include #include +#include #include "sd-event.h" diff --git a/src/test/test-hashmap-plain.c b/src/test/test-hashmap-plain.c index eb211c3ed7..5cc84e884d 100644 --- a/src/test/test-hashmap-plain.c +++ b/src/test/test-hashmap-plain.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "alloc-util.h" #include "hashmap.h" #include "log.h" diff --git a/src/test/test-json.c b/src/test/test-json.c index 065e84dad7..91e14a4726 100644 --- a/src/test/test-json.c +++ b/src/test/test-json.c @@ -3,6 +3,7 @@ #include #include #include +#include #include "sd-json.h" diff --git a/src/test/test-loop-block.c b/src/test/test-loop-block.c index b9a1ffd540..a1fdac63e5 100644 --- a/src/test/test-loop-block.c +++ b/src/test/test-loop-block.c @@ -6,6 +6,7 @@ #include #include #include +#include #include "alloc-util.h" #include "capability-util.h" diff --git a/src/test/test-macro.c b/src/test/test-macro.c index 3b08874b6b..2de70723aa 100644 --- a/src/test/test-macro.c +++ b/src/test/test-macro.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-id128.h" diff --git a/src/test/test-memfd-util.c b/src/test/test-memfd-util.c index e3d9c9fff6..2cfae57f66 100644 --- a/src/test/test-memfd-util.c +++ b/src/test/test-memfd-util.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "errno-util.h" #include "fd-util.h" #include "memfd-util.h" diff --git a/src/test/test-mount-util.c b/src/test/test-mount-util.c index fb2cab3da8..6894429b6a 100644 --- a/src/test/test-mount-util.c +++ b/src/test/test-mount-util.c @@ -3,6 +3,7 @@ #include #include #include +#include #include "alloc-util.h" #include "capability-util.h" diff --git a/src/test/test-namespace.c b/src/test/test-namespace.c index 14558e8794..b301f3ea4b 100644 --- a/src/test/test-namespace.c +++ b/src/test/test-namespace.c @@ -6,6 +6,7 @@ #include #include #include +#include #include "sd-id128.h" diff --git a/src/test/test-os-util.c b/src/test/test-os-util.c index e40c4b49a2..fcab1139c2 100644 --- a/src/test/test-os-util.c +++ b/src/test/test-os-util.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "fileio.h" #include "log.h" diff --git a/src/test/test-path.c b/src/test/test-path.c index 317537700a..d282cfbf89 100644 --- a/src/test/test-path.c +++ b/src/test/test-path.c @@ -2,6 +2,7 @@ #include #include +#include #include "all-units.h" #include "alloc-util.h" diff --git a/src/test/test-proc-cmdline.c b/src/test/test-proc-cmdline.c index 8ae9d811e0..478974b0a9 100644 --- a/src/test/test-proc-cmdline.c +++ b/src/test/test-proc-cmdline.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "alloc-util.h" #include "errno-util.h" diff --git a/src/test/test-psi-util.c b/src/test/test-psi-util.c index 1bb25c2b11..bf5187134e 100644 --- a/src/test/test-psi-util.c +++ b/src/test/test-psi-util.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "fd-util.h" #include "fileio.h" #include "parse-util.h" diff --git a/src/test/test-rlimit-util.c b/src/test/test-rlimit-util.c index c8abd9d98d..6e8ffec628 100644 --- a/src/test/test-rlimit-util.c +++ b/src/test/test-rlimit-util.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #if HAVE_VALGRIND_VALGRIND_H #include #endif diff --git a/src/test/test-set.c b/src/test/test-set.c index 16351676d4..4c1872d636 100644 --- a/src/test/test-set.c +++ b/src/test/test-set.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "random-util.h" #include "set.h" #include "strv.h" diff --git a/src/test/test-string-util.c b/src/test/test-string-util.c index fa2de0f12b..2439dd12ec 100644 --- a/src/test/test-string-util.c +++ b/src/test/test-string-util.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "alloc-util.h" #include "extract-word.h" #include "locale-util.h" diff --git a/src/test/test-tmpfile-util.c b/src/test/test-tmpfile-util.c index 413bbf59ab..cd46716516 100644 --- a/src/test/test-tmpfile-util.c +++ b/src/test/test-tmpfile-util.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "alloc-util.h" #include "argv-util.h" diff --git a/src/test/test-uid-range.c b/src/test/test-uid-range.c index 8c4c6eb264..74346c4cd6 100644 --- a/src/test/test-uid-range.c +++ b/src/test/test-uid-range.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "errno-util.h" #include "fd-util.h" #include "fileio.h" diff --git a/src/test/test-unit-file.c b/src/test/test-unit-file.c index 2f8b288e53..44f0c3fb02 100644 --- a/src/test/test-unit-file.c +++ b/src/test/test-unit-file.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "argv-util.h" #include "fileio.h" #include "initrd-util.h" diff --git a/src/test/test-unit-name.c b/src/test/test-unit-name.c index 4eb9f052b2..672162244f 100644 --- a/src/test/test-unit-name.c +++ b/src/test/test-unit-name.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-daemon.h" #include "sd-id128.h" diff --git a/src/test/test-user-util.c b/src/test/test-user-util.c index 4df9cb5edc..4fee2ba7c2 100644 --- a/src/test/test-user-util.c +++ b/src/test/test-user-util.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "alloc-util.h" #include "format-util.h" #include "libcrypt-util.h" diff --git a/src/test/test-varlink.c b/src/test/test-varlink.c index efb09ee2dd..b298b9cfbf 100644 --- a/src/test/test-varlink.c +++ b/src/test/test-varlink.c @@ -4,6 +4,7 @@ #include #include #include +#include #include "sd-event.h" #include "sd-json.h" diff --git a/src/test/test-vpick.c b/src/test/test-vpick.c index eed650ca4d..8b64531b1f 100644 --- a/src/test/test-vpick.c +++ b/src/test/test-vpick.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "fd-util.h" #include "fileio.h" #include "fs-util.h" diff --git a/src/test/test-watch-pid.c b/src/test/test-watch-pid.c index dd1fa49428..0a325dfb08 100644 --- a/src/test/test-watch-pid.c +++ b/src/test/test-watch-pid.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ +#include + #include "manager.h" #include "process-util.h" #include "rm-rf.h" diff --git a/src/timesync/timesyncd-manager.c b/src/timesync/timesyncd-manager.c index f4cea2ddd7..031793ea77 100644 --- a/src/timesync/timesyncd-manager.c +++ b/src/timesync/timesyncd-manager.c @@ -5,6 +5,7 @@ #include #include #include +#include #include "sd-bus.h" #include "sd-daemon.h" diff --git a/src/timesync/timesyncd.c b/src/timesync/timesyncd.c index 822662c016..40305c046b 100644 --- a/src/timesync/timesyncd.c +++ b/src/timesync/timesyncd.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-event.h" #include "sd-messages.h" diff --git a/src/udev/udev-manager.c b/src/udev/udev-manager.c index 09ab8997e1..280626da9e 100644 --- a/src/udev/udev-manager.c +++ b/src/udev/udev-manager.c @@ -2,6 +2,7 @@ #include #include +#include #include "sd-varlink.h" diff --git a/src/udev/udev-spawn.c b/src/udev/udev-spawn.c index bbbbd4e2fc..1f167b89ab 100644 --- a/src/udev/udev-spawn.c +++ b/src/udev/udev-spawn.c @@ -1,5 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ +#include + #include "sd-event.h" #include "build-path.h" diff --git a/src/udev/udev-watch.c b/src/udev/udev-watch.c index 49cae65725..c8f555ef71 100644 --- a/src/udev/udev-watch.c +++ b/src/udev/udev-watch.c @@ -6,6 +6,7 @@ #include #include +#include #include "alloc-util.h" #include "blockdev-util.h" diff --git a/src/userdb/userdbd-manager.c b/src/userdb/userdbd-manager.c index b634abd4b5..6e0d5e4a2a 100644 --- a/src/userdb/userdbd-manager.c +++ b/src/userdb/userdbd-manager.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "sd-daemon.h" diff --git a/src/varlinkctl/varlinkctl.c b/src/varlinkctl/varlinkctl.c index e1d74709c3..9e32156239 100644 --- a/src/varlinkctl/varlinkctl.c +++ b/src/varlinkctl/varlinkctl.c @@ -3,6 +3,7 @@ #include #include #include +#include #include "sd-daemon.h" #include "sd-varlink.h" diff --git a/src/volatile-root/volatile-root.c b/src/volatile-root/volatile-root.c index 0e8c2ea0e9..4febb162bd 100644 --- a/src/volatile-root/volatile-root.c +++ b/src/volatile-root/volatile-root.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: LGPL-2.1-or-later */ #include +#include #include "alloc-util.h" #include "blockdev-util.h"