From 4f25330d871498f3a3538c8d494624d92e829f3e Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 18 Jun 2024 09:55:48 +0200 Subject: [PATCH] tmpfiles: improve debug logging around O_NOATIME fallback --- src/tmpfiles/tmpfiles.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/tmpfiles/tmpfiles.c b/src/tmpfiles/tmpfiles.c index ca163fd5f7..e3eca2ef27 100644 --- a/src/tmpfiles/tmpfiles.c +++ b/src/tmpfiles/tmpfiles.c @@ -547,14 +547,13 @@ static DIR* xopendirat_nomod(int dirfd, const char *path) { return dir; if (!IN_SET(errno, ENOENT, ELOOP)) - log_debug_errno(errno, "Cannot open %sdirectory \"%s\": %m", dirfd == AT_FDCWD ? "" : "sub", path); - - if (errno != EPERM) + log_debug_errno(errno, "Cannot open %sdirectory \"%s\" with O_NOATIME: %m", dirfd == AT_FDCWD ? "" : "sub", path); + if (!ERRNO_IS_PRIVILEGE(errno)) return NULL; dir = xopendirat(dirfd, path, O_NOFOLLOW); if (!dir) - log_debug_errno(errno, "Cannot open %sdirectory \"%s\": %m", dirfd == AT_FDCWD ? "" : "sub", path); + log_debug_errno(errno, "Cannot open %sdirectory \"%s\" with or without O_NOATIME: %m", dirfd == AT_FDCWD ? "" : "sub", path); return dir; }