diff --git a/TODO b/TODO index 07f65ec80e..aded50fee6 100644 --- a/TODO +++ b/TODO @@ -378,8 +378,6 @@ Features: * show whether a service has out-of-date configuration in "systemctl status" by using mtime data of ConfigurationDirectory=. -* replace all remaining uses of fgets() + LINE_MAX by read_line() - * Add AddUser= setting to unit files, similar to DynamicUser=1 which however creates a static, persistent user rather than a dynamic, transient user. We can leverage code from sysusers.d for this. @@ -460,8 +458,6 @@ Features: * define gpt header bits to select volatility mode -* ProtectKernelLogs= (drops CAP_SYSLOG, add seccomp for syslog() syscall, and DeviceAllow to /dev/kmsg) in service files - * ProtectClock= (drops CAP_SYS_TIMES, adds seecomp filters for settimeofday, adjtimex), sets DeviceAllow o /dev/rtc * ProtectTracing= (drops CAP_SYS_PTRACE, blocks ptrace syscall, makes /sys/kernel/tracing go away) @@ -519,7 +515,7 @@ Features: * when we detect that there are waiting jobs but no running jobs, do something -* push CPUAffinity= also into the "cpuset" cgroup controller (only after the cpuset controller got ported to the unified hierarchy) +* push CPUAffinity= also into the "cpuset" cgroup controller * PID 1 should send out sd_notify("WATCHDOG=1") messages (for usage in the --user mode, and when run via nspawn) @@ -580,8 +576,6 @@ Features: * what to do about udev db binary stability for apps? (raw access is not an option) -* man: maybe use the word "inspect" rather than "introspect"? - * systemctl: if some operation fails, show log output? * systemctl edit: use equivalent of cat() to insert existing config as a comment, prepended with #. diff --git a/src/basic/process-util.c b/src/basic/process-util.c index d60d8275ca..743c7b1dad 100644 --- a/src/basic/process-util.c +++ b/src/basic/process-util.c @@ -1340,9 +1340,8 @@ int safe_fork_full( } } else if (flags & FORK_STDOUT_TO_STDERR) { - if (dup2(STDERR_FILENO, STDOUT_FILENO) < 0) { - log_full_errno(prio, r, "Failed to connect stdout to stderr: %m"); + log_full_errno(prio, errno, "Failed to connect stdout to stderr: %m"); _exit(EXIT_FAILURE); } }