treewide: use log_*_errno whenever %m is in the format string
If the format string contains %m, clearly errno must have a meaningful
value, so we might as well use log_*_errno to have ERRNO= logged.
Using:
find . -name '*.[ch]' | xargs sed -r -i -e \
's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/'
Plus some whitespace, linewrap, and indent adjustments.
This commit is contained in:
@@ -285,7 +285,7 @@ static void do_journal_append(char *file) {
|
||||
|
||||
f = open(file, O_RDONLY|O_CLOEXEC);
|
||||
if (f < 0) {
|
||||
log_error("Failed to read bootchart data: %m");
|
||||
log_error_errno(errno, "Failed to read bootchart data: %m");
|
||||
return;
|
||||
}
|
||||
n = loop_read(f, p + 10, BOOTCHART_MAX, false);
|
||||
@@ -434,7 +434,7 @@ int main(int argc, char *argv[]) {
|
||||
/* caught signal, probably HUP! */
|
||||
break;
|
||||
}
|
||||
log_error("nanosleep() failed: %m");
|
||||
log_error_errno(errno, "nanosleep() failed: %m");
|
||||
exit(EXIT_FAILURE);
|
||||
}
|
||||
} else {
|
||||
|
||||
@@ -146,7 +146,7 @@ void log_sample(int sample, struct list_sample_data **ptr) {
|
||||
/* block stuff */
|
||||
vmstat = openat(procfd, "vmstat", O_RDONLY);
|
||||
if (vmstat == -1) {
|
||||
log_error("Failed to open /proc/vmstat: %m");
|
||||
log_error_errno(errno, "Failed to open /proc/vmstat: %m");
|
||||
exit(EXIT_FAILURE);
|
||||
}
|
||||
}
|
||||
@@ -178,7 +178,7 @@ vmstat_next:
|
||||
/* overall CPU utilization */
|
||||
schedstat = openat(procfd, "schedstat", O_RDONLY);
|
||||
if (schedstat == -1) {
|
||||
log_error("Failed to open /proc/schedstat: %m");
|
||||
log_error_errno(errno, "Failed to open /proc/schedstat: %m");
|
||||
exit(EXIT_FAILURE);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user