From fb76275a7abaabaaac40ee61186fe5ca0b6950ec Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Tue, 16 Jan 2018 22:22:14 +0900 Subject: [PATCH 1/3] man: remove duplicated line Follow-up for c46bc7e2162d774f55847c1a8cb9d49085cf89bb. --- man/machinectl.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/man/machinectl.xml b/man/machinectl.xml index 94f2ba511c..1adebf5da0 100644 --- a/man/machinectl.xml +++ b/man/machinectl.xml @@ -439,7 +439,6 @@ specified, the connection is made to the local host instead. This works similar to login but immediately invokes a user process. This command runs the - specified executable with the specified arguments, or specified executable with the specified arguments, or the default shell for the user if none is specified, or /bin/sh if no default shell is found. By default, From 47dbb99ad7bb2e7d06c712d9f60e767f9b12a457 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Tue, 16 Jan 2018 23:00:39 +0900 Subject: [PATCH 2/3] virt: add comment that we need to use sscanf() Follow-up for 13e0f9fe8334859ee86f4ff725374d1d83f5baf7. See PR #7890 and comment in PR #7581. --- src/basic/virt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/basic/virt.c b/src/basic/virt.c index 9b6abf9f19..f4796b53bc 100644 --- a/src/basic/virt.c +++ b/src/basic/virt.c @@ -222,6 +222,8 @@ static int detect_vm_xen_dom0(void) { if (r == 0) { unsigned long features; + /* Here, we need to use sscanf() instead of safe_atoul() + * as the string lacks the leading "0x". */ r = sscanf(domcap, "%lx", &features); if (r == 1) { r = !!(features & (1U << XENFEAT_dom0)); From c7612b20052d9151f60a96623b8743cbac88390d Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Tue, 16 Jan 2018 23:25:56 +0900 Subject: [PATCH 3/3] man: mention that systemctl is-active or is-failed do not load units See the discussion in the issue #7875. --- man/systemctl.xml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/man/systemctl.xml b/man/systemctl.xml index 60882e5aa3..375b91a9bb 100644 --- a/man/systemctl.xml +++ b/man/systemctl.xml @@ -877,6 +877,10 @@ Sun 2017-02-26 20:57:49 EST 2h 3min left Sun 2017-02-26 11:56:36 EST 6h ago non-zero otherwise. Unless is specified, this will also print the current unit state to standard output. + + Unlike status or show commands, this does not + load units. So, when a specified unit is an alias of another unit and is not loaded, + then this outputs "inactive", even if the aliased unit is active. @@ -889,6 +893,10 @@ Sun 2017-02-26 20:57:49 EST 2h 3min left Sun 2017-02-26 11:56:36 EST 6h ago non-zero otherwise. Unless is specified, this will also print the current unit state to standard output. + + Unlike status or show commands, this does not + load units. So, when a specified unit is an alias of another unit and is not loaded, + then this outputs "inactive", even if the aliased unit is failed. @@ -987,6 +995,9 @@ Jan 12 10:46:45 example.com bluetoothd[8900]: gatt-time-server: Input/output err are always exposed as properties ending in the …USec suffix even if a matching configuration options end in …Sec, because microseconds is the normalized time unit used by the system and service manager. + + As similar to status command, systemd implicitly loads units as necessary. + See also status command for the detail.