From 6c279977e3e065e8d3c14747d19dc2bf80150490 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 7 Jun 2022 10:50:42 +0200 Subject: [PATCH] basic/unit-file: make sure we don't call streq() on NULL add_names is called in two places, with fragment_basename=NULL in one of them. gcc warns that it can be NULL. Fixes #23646. --- src/basic/unit-file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/basic/unit-file.c b/src/basic/unit-file.c index 83c29bb25f..ac0236d635 100644 --- a/src/basic/unit-file.c +++ b/src/basic/unit-file.c @@ -689,6 +689,7 @@ static int add_names( return log_debug_errno(r, "Cannot find instance fragment %s: %m", inst); if (inst_fragment && + fragment_basename && !streq(basename(inst_fragment), fragment_basename)) { log_debug("Instance %s has fragment %s and is not an alias of %s.", inst, inst_fragment, unit_name);