SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

terminal-util: calculate array index only once

Browse Source
This commit is contained in:
Lennart Poettering
2026-07-02 08:18:36 +02:00
parent 03b498d8a8
commit 72c6ac77e3
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/basic/terminal-util.c
+5 -5
View File
@@ -564,8 +564,7 @@ int show_menu(char **x,
if (break_lines > 2)
break_lines--;
/* The first page gets two extra lines, since we want to show
* a title */
/* The first page gets two extra lines, since we want to show a title */
size_t break_modulo = break_lines;
if (break_modulo > 3)
break_modulo -= 3;
@@ -575,17 +574,18 @@ int show_menu(char **x,
for (size_t j = 0; j < n_columns; j++) {
_cleanup_free_ char *e = NULL;
if (j * per_column + i >= n)
size_t p = j * per_column + i;
if (p >= n)
break;
e = ellipsize(x[j * per_column + i], column_width, ellipsize_percentage);
e = ellipsize(x[p], column_width, ellipsize_percentage);
if (!e)
return -ENOMEM;
if (with_numbers)
printf("%s%4zu)%s ",
ansi_grey(),
j * per_column + i + 1,
p + 1,
ansi_normal());
if (grey_prefix && startswith(e, grey_prefix)) {