shared/json: fix memory leak on failed normalization

We need to increase the counter immediately after taking the ref, otherwise we may not unref it properly if we fail before incrementing.
2022-05-10 12:58:49 +02:00
parent bac06497fe
commit 7e4be6a584
2 changed files with 4 additions and 2 deletions
@@ -4655,10 +4655,11 @@ int json_variant_normalize(JsonVariant **v) {
        if (!a)
                return -ENOMEM;

-        for (i = 0; i < m; i++) {
+        for (i = 0; i < m; ) {
                a[i] = json_variant_ref(json_variant_by_index(*v, i));
+                i++;

-                r = json_variant_normalize(a + i);
+                r = json_variant_normalize(&a[i-1]);
                if (r < 0)
                        goto finish;
        }