diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c index 09f7baf082..4cadff7f6f 100644 --- a/src/udev/udev-event.c +++ b/src/udev/udev-event.c @@ -720,10 +720,12 @@ int udev_build_argv(struct udev *udev, char *cmd, int *argc, char *argv[]) { pos = cmd; while (pos != NULL && pos[0] != '\0') { - if (pos[0] == '\'') { - /* do not separate quotes */ + if (IN_SET(pos[0], '\'', '"')) { + /* do not separate quotes or double quotes */ + char delim[2] = { pos[0], '\0' }; + pos++; - argv[i] = strsep(&pos, "\'"); + argv[i] = strsep(&pos, delim); if (pos != NULL) while (pos[0] == ' ') pos++; diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c index 2c5bcc38cd..5ab697e399 100644 --- a/src/udev/udev-rules.c +++ b/src/udev/udev-rules.c @@ -718,6 +718,7 @@ static void attr_subst_subdir(char *attr, size_t len) { static int get_key(struct udev *udev, char **line, char **key, enum operation_type *op, char **value) { char *linepos; char *temp; + unsigned i, j; linepos = *line; if (linepos == NULL || linepos[0] == '\0') @@ -793,14 +794,25 @@ static int get_key(struct udev *udev, char **line, char **key, enum operation_ty *value = linepos; /* terminate */ - temp = strchr(linepos, '"'); - if (!temp) - return -1; - temp[0] = '\0'; - temp++; + for (i = 0, j = 0; ; i++, j++) { + + if (linepos[i] == '"') + break; + + if (linepos[i] == '\0') + return -1; + + /* double quotes can be escaped */ + if (linepos[i] == '\\') + if (linepos[i+1] == '"') + i++; + + linepos[j] = linepos[i]; + } + linepos[j] = '\0'; /* move line to next key */ - *line = temp; + *line = linepos + i + 1; return 0; } diff --git a/test/udev-test.pl b/test/udev-test.pl index 7e33479004..0d348e5c08 100755 --- a/test/udev-test.pl +++ b/test/udev-test.pl @@ -330,6 +330,30 @@ EOF exp_name => "foo7" , rules => < "program arguments combined with escaped double quotes, part 1", + devpath => "/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda5", + exp_name => "foo2" , + rules => < "program arguments combined with escaped double quotes, part 2", + devpath => "/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda5", + exp_name => "foo2" , + rules => < "program arguments combined with escaped double quotes, part 3", + devpath => "/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda5", + exp_name => "foo2" , + rules => <