From 8292b859f39bfcb14a1687242b20cb8645b6ea15 Mon Sep 17 00:00:00 2001 From: Mike Yuan Date: Sun, 18 Jan 2026 22:40:30 +0100 Subject: [PATCH] core/cgroup: drop trusted.survive_final_kill_signal fallback for kernel < 5.7 --- src/core/cgroup.c | 33 +++------------------------------ src/shared/killall.c | 3 --- 2 files changed, 3 insertions(+), 33 deletions(-) diff --git a/src/core/cgroup.c b/src/core/cgroup.c index 9a218ff058..c4336cd80e 100644 --- a/src/core/cgroup.c +++ b/src/core/cgroup.c @@ -944,39 +944,12 @@ static void cgroup_delegate_xattr_apply(Unit *u) { } static void cgroup_survive_xattr_apply(Unit *u) { - int r; - assert(u); - CGroupRuntime *crt = unit_get_cgroup_runtime(u); - if (!crt) - return; - - if (u->survive_final_kill_signal) { - r = cg_set_xattr( - crt->cgroup_path, - "user.survive_final_kill_signal", - "1", - 1, - /* flags= */ 0); - /* user xattr support was added in kernel v5.7 */ - if (ERRNO_IS_NEG_NOT_SUPPORTED(r)) - r = cg_set_xattr( - crt->cgroup_path, - "trusted.survive_final_kill_signal", - "1", - 1, - /* flags= */ 0); - if (r < 0) - log_unit_debug_errno(u, - r, - "Failed to set 'survive_final_kill_signal' xattr on control " - "group %s, ignoring: %m", - empty_to_root(crt->cgroup_path)); - } else { + if (u->survive_final_kill_signal) + unit_set_xattr_graceful(u, "user.survive_final_kill_signal", "1", 1); + else unit_remove_xattr_graceful(u, "user.survive_final_kill_signal"); - unit_remove_xattr_graceful(u, "trusted.survive_final_kill_signal"); - } } static void cgroup_xattr_apply(Unit *u) { diff --git a/src/shared/killall.c b/src/shared/killall.c index 729e0e2480..d81f385634 100644 --- a/src/shared/killall.c +++ b/src/shared/killall.c @@ -64,9 +64,6 @@ static bool is_in_survivor_cgroup(const PidRef *pid) { } r = cg_get_xattr_bool(cgroup_path, "user.survive_final_kill_signal"); - /* user xattr support was added to kernel v5.7, try with the trusted namespace as a fallback */ - if (ERRNO_IS_NEG_XATTR_ABSENT(r)) - r = cg_get_xattr_bool(cgroup_path, "trusted.survive_final_kill_signal"); if (r < 0 && !ERRNO_IS_NEG_XATTR_ABSENT(r)) log_debug_errno(r, "Failed to get survive_final_kill_signal xattr of %s, ignoring: %m",