From 8954e891959448783e66ec5ee7a6bb6d4a0be82f Mon Sep 17 00:00:00 2001 From: Luca Boccassi Date: Tue, 3 Aug 2021 14:53:31 +0100 Subject: [PATCH] creds: assert that credential read from file fits in data struct Coverity CID#1458114 --- src/shared/creds-util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/shared/creds-util.c b/src/shared/creds-util.c index ee279e0c9c..3bc5fbef51 100644 --- a/src/shared/creds-util.c +++ b/src/shared/creds-util.c @@ -299,6 +299,8 @@ int get_credential_host_secret(CredentialSecretFlags flags, void **ret, size_t * if (ret) { void *copy; + assert(sz <= sizeof(f->data)); /* Ensure we don't read past f->data bounds */ + copy = memdup(f->data, sz); if (!copy) return -ENOMEM;