From 1b6a0f0b3575602ddb1b675a1d44466655cb9935 Mon Sep 17 00:00:00 2001 From: Evgeny Vereshchagin Date: Sat, 31 Oct 2015 22:00:32 +0300 Subject: [PATCH 1/2] tests: lookup_paths_init depends on SYSTEMD_UNIT_PATH. Test it --- src/test/test-path-lookup.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/test/test-path-lookup.c b/src/test/test-path-lookup.c index 92ffa65925..65cb894ff7 100644 --- a/src/test/test-path-lookup.c +++ b/src/test/test-path-lookup.c @@ -19,6 +19,7 @@ along with systemd; If not, see . ***/ +#include #include #include "log.h" @@ -30,19 +31,27 @@ static void test_paths(ManagerRunningAs running_as, bool personal) { char template[] = "/tmp/test-path-lookup.XXXXXXX"; - _cleanup_lookup_paths_free_ LookupPaths lp = {}; - char *exists, *not; + _cleanup_lookup_paths_free_ LookupPaths lp_without_env = {}; + _cleanup_lookup_paths_free_ LookupPaths lp_with_env = {}; + char *exists, *not, *systemd_unit_path; assert_se(mkdtemp(template)); exists = strjoina(template, "/exists"); assert_se(mkdir(exists, 0755) == 0); not = strjoina(template, "/not"); - assert_se(lookup_paths_init(&lp, running_as, personal, NULL, exists, not, not) == 0); + assert_se(unsetenv("SYSTEMD_UNIT_PATH") == 0); + assert_se(lookup_paths_init(&lp_without_env, running_as, personal, NULL, exists, not, not) == 0); - assert_se(!strv_isempty(lp.unit_path)); - assert_se(strv_contains(lp.unit_path, exists)); - assert_se(strv_contains(lp.unit_path, not)); + assert_se(!strv_isempty(lp_without_env.unit_path)); + assert_se(strv_contains(lp_without_env.unit_path, exists)); + assert_se(strv_contains(lp_without_env.unit_path, not)); + + systemd_unit_path = strjoina(template, "/systemd-unit-path"); + assert_se(setenv("SYSTEMD_UNIT_PATH", systemd_unit_path, 1) == 0); + assert_se(lookup_paths_init(&lp_with_env, running_as, personal, NULL, exists, not, not) == 0); + assert_se(strv_length(lp_with_env.unit_path) == 1); + assert_se(streq(lp_with_env.unit_path[0], systemd_unit_path)); assert_se(rm_rf(template, REMOVE_ROOT|REMOVE_PHYSICAL) >= 0); } From aa3e4400e30a7de2aa907639dc7e305c0b0a2178 Mon Sep 17 00:00:00 2001 From: Evgeny Vereshchagin Date: Sat, 31 Oct 2015 23:07:47 +0300 Subject: [PATCH 2/2] man: MANAGER_SYSTEM understands SYSTEMD_UNIT_PATH too --- man/systemd.unit.xml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/man/systemd.unit.xml b/man/systemd.unit.xml index 33f1309268..a4eeccaed4 100644 --- a/man/systemd.unit.xml +++ b/man/systemd.unit.xml @@ -263,10 +263,8 @@ in directories listed earlier override files with the same name in directories lower in the list. - When systemd is running in user mode - () and the variable - $SYSTEMD_UNIT_PATH is set, the contents of this - variable overrides the unit load path. If + When the variable $SYSTEMD_UNIT_PATH is set, + the contents of this variable overrides the unit load path. If $SYSTEMD_UNIT_PATH ends with an empty component (:), the usual unit load path will be appended to the contents of the variable.