From 91927a2a1281be60f931e90d78e851d8ffd0688f Mon Sep 17 00:00:00 2001 From: cverorg <292680828+cverorg@users.noreply.github.com> Date: Mon, 31 Aug 2026 01:31:17 +0900 Subject: [PATCH] Revert "hwdb: add support for PineTab2 to 60-sensor.hwdb (#35304)" This reverts commit bc4a027f9cb66d56fd1305f41bed25751305fc27. The match key names the chip, not the machine. `of:NTC` describes the sensor node, and the Pine64 PineNote carries the same silan sc7a20 mounted in a different orientation, so it presents an identical modalias: $ cat /sys/bus/iio/devices/iio:device2/../modalias of:NaccelerometerT(null)Csilan,sc7a20 On a device-tree machine there is no `/sys/class/dmi/id/modalias` to narrow it with, so 60-sensor.rules looks up `sensor:modalias:of:...:` with the DMI half empty and both boards land on the one entry. A second, PineNote-scoped entry cannot be written: it would carry the same match string and simply shadow the first. The entry also overrides a correct value. The PineNote's device tree supplies the matrix and the kernel publishes it: $ cat /sys/bus/iio/devices/iio:device2/mount_matrix -1, 0, 0; 0, 1, 0; 0, 0, 1 but udev then replaces it with the PineTab2's, and the four orientations collapse into two, both landscape -- iio-sensor-proxy only ever reports `normal` and `bottom-up`, so the display never selects portrait. Where the kernel supplies a mount matrix, hwdb has nothing to add here; where it does not, a local hwdb entry remains available. Tested on a PineNote v1.2, kernel 6.12.11, systemd 257. Closes #43321 --- hwdb.d/60-sensor.hwdb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/hwdb.d/60-sensor.hwdb b/hwdb.d/60-sensor.hwdb index a70b42139e..5a38d6c83d 100644 --- a/hwdb.d/60-sensor.hwdb +++ b/hwdb.d/60-sensor.hwdb @@ -901,13 +901,6 @@ sensor:modalias:acpi:MXC6655:*:dmi:*:svnDefaultstring*:pnP612F:* # P612F sensor:modalias:acpi:SMO8500:*:dmi:*:svnPEAQ:pnPEAQPMMC1010MD99187:* # MMC1010 2-in-1 ACCEL_MOUNT_MATRIX=-1, 0, 0; 0, 1, 0; 0, 0, 1 -######################################### -# Pine64 -######################################### - -sensor:modalias:of:NaccelerometerT_null_Csilan,sc7a20:* # PineTab2 - ACCEL_MOUNT_MATRIX=0, 0, -1; 1, 0, 0; 0, -1, 0 - ######################################### # Pipo #########################################