From 91d5fad9fbbe91617c503bd48d3f16b1f47e3f50 Mon Sep 17 00:00:00 2001 From: Mike Yuan Date: Thu, 17 Apr 2025 23:57:57 +0200 Subject: [PATCH] bus-unit-util: do not trigger assertion on "ExecStart=@" extract_first_word() normalizes empty string to NULL, triggering the assertion on input string in strv_split_full(). --- src/shared/bus-unit-util.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/shared/bus-unit-util.c b/src/shared/bus-unit-util.c index c0572aff15..c7bb1b2533 100644 --- a/src/shared/bus-unit-util.c +++ b/src/shared/bus-unit-util.c @@ -354,6 +354,10 @@ static int bus_append_exec_command(sd_bus_message *m, const char *field, const c r = extract_first_word(&eq, &path, NULL, EXTRACT_UNQUOTE|EXTRACT_CUNESCAPE); if (r < 0) return log_error_errno(r, "Failed to parse path: %m"); + if (r == 0) + return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "No executable path specified, refusing."); + if (isempty(eq)) + return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Got empty command line, refusing."); } r = strv_split_full(&l, eq, NULL, EXTRACT_UNQUOTE|EXTRACT_CUNESCAPE);