From 925484aacbf2c70db7fc2e7a89c80a8d02ccf3b8 Mon Sep 17 00:00:00 2001 From: Benjamin Robin Date: Tue, 16 Feb 2021 23:18:28 +0100 Subject: [PATCH] basic: use -EINVAL for _MANAGED_OOM_PREFERENCE_INVALID Follow-up of #11484 --- src/basic/cgroup-util.h | 2 +- src/core/dbus-cgroup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/basic/cgroup-util.h b/src/basic/cgroup-util.h index 420ddb59c0..30b4819eb3 100644 --- a/src/basic/cgroup-util.h +++ b/src/basic/cgroup-util.h @@ -297,7 +297,7 @@ typedef enum ManagedOOMPreference { MANAGED_OOM_PREFERENCE_AVOID = 1, MANAGED_OOM_PREFERENCE_OMIT = 2, _MANAGED_OOM_PREFERENCE_MAX, - _MANAGED_OOM_PREFERENCE_INVALID = -1 + _MANAGED_OOM_PREFERENCE_INVALID = -EINVAL, } ManagedOOMPreference; const char* managed_oom_preference_to_string(ManagedOOMPreference a) _const_; diff --git a/src/core/dbus-cgroup.c b/src/core/dbus-cgroup.c index 2b8b833fe3..6652c212f1 100644 --- a/src/core/dbus-cgroup.c +++ b/src/core/dbus-cgroup.c @@ -1732,7 +1732,7 @@ int bus_cgroup_set_property( p = managed_oom_preference_from_string(pref); if (p < 0) - return -EINVAL; + return p; if (!UNIT_WRITE_FLAGS_NOOP(flags)) { c->moom_preference = p;